New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use DOMAIN constants and standards for EQ3 thermostate #19242

Merged
merged 1 commit into from Dec 14, 2018

Conversation

Projects
None yet
4 participants
@marchingphoenix
Copy link
Contributor

marchingphoenix commented Dec 13, 2018

Description:

BREAKING CHANGE
Change STATE_AUTO to STATE_HEAT and STATE_AWAY to STATE_ECO to conform to climate DOMAIN standards.
Change made to fix Alexa/Google Assistant support for this component.

This will break any automations that rely on these states.

Automation state changes:

Old New
auto heat
away eco

Results of change

  • Google Assistant
    • Setting mode to Heat will now display temperature controls in the app. Can set temp via voice.
    • Setting mode to Away will actually work.
  • Alexa
    • Setting mode to Away will now work.

Related issue (if applicable): fixes #17333

**Pull request in home-assistant.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

No Change

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.
    N/A

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@reaper7

This comment has been minimized.

Copy link

reaper7 commented on 0f7eb70 Dec 13, 2018

Yesterday I tested STATE_HEAT instead STATE_AUTO and it works.

I have not checked yet AWAY->ECO

@marchingphoenix - you are sure STATE_MANUAL = 'manual' should be removed

@@ -21,8 +22,6 @@
_LOGGER = logging.getLogger(__name__)

STATE_BOOST = 'boost'

This comment has been minimized.

@balloob

balloob Dec 13, 2018

Member

We should remove this too.

This comment has been minimized.

@marchingphoenix

marchingphoenix Dec 13, 2018

Contributor

Longer term, definitely. I'm hesitant to do this now as i don't have one of these devices to test against and don't want to remove functionality.

@fabaff fabaff changed the title BREAKING CHANGE - eq3 thermostat: update to use DOMAIN constants and standards Update to use DOMAIN constants and standards for EQ3 thermostate Dec 13, 2018

@marchingphoenix

This comment has been minimized.

Copy link
Contributor

marchingphoenix commented Dec 13, 2018

@marchingphoenix - you are sure STATE_MANUAL = 'manual' should be removed

Yep, i didn't change this mode, all i did was remove setting STATE_MANUAL from this file and instead import climate.STATE_MANUAL and use that.

@balloob balloob merged commit e886576 into home-assistant:dev Dec 14, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on fix-eq3-modes at 92.887%
Details

@wafflebot wafflebot bot removed the in progress label Dec 14, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 14, 2018

Merge branch 'dev' into current
* dev: (88 commits)
  huawei_lte: Fetch only required data (home-assistant#17618)
  Adding support for Plum Lightpad (home-assistant#16576)
  Fix restore state for manual alarm control panel (home-assistant#19284)
  Set InsteonEntity name to be combo of description and address. (home-assistant#17262)
  Device config for Fibaro hub integration (home-assistant#19171)
  Add air pollutants component (home-assistant#18707)
  Updated ELIQ Online sensor to async API (home-assistant#19248)
  Set unavailable when unreachable (home-assistant#19012)
  Make variable `entity_id` available to value_template for MQTT binary sensor (home-assistant#19195)
  home-assistant#17333: update to use DOMAIN constants and standards. (home-assistant#19242)
  Fix race in entity_platform.async_add_entities (home-assistant#19222)
  Fix race in entity_platform.async_add_entities (home-assistant#19222)
  Bumped version to 0.84.2
  Fix call to super() (home-assistant#19279)
  Fix OwnTracks deadlocking (home-assistant#19260)
  Fix list (fixes home-assistant#19235) (home-assistant#19258)
  Add automation and script events to logbook filter events (home-assistant#19253)
  Bump aioasuswrt (home-assistant#19229)
  Review comments
  Move check to websocket
  ...

@marchingphoenix marchingphoenix deleted the marchingphoenix:fix-eq3-modes branch Dec 14, 2018

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment