New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ELIQ Online sensor to async API #19248

Merged
merged 2 commits into from Dec 14, 2018

Conversation

Projects
None yet
5 participants
@molobrakos
Copy link
Collaborator

molobrakos commented Dec 13, 2018

Description:

External API now supports asyncio.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@molobrakos molobrakos force-pushed the molobrakos:eliq-session branch from 5863ec2 to e4e7bd2 Dec 13, 2018

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Looks good! An optional clean up possible.

@@ -13,8 +13,9 @@
from homeassistant.const import (CONF_ACCESS_TOKEN, CONF_NAME, STATE_UNKNOWN)

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Dec 14, 2018

Member

It would be nice to clean up the use of STATE_UNKNOWN while we're here. Use None to represent unknown state.

This comment has been minimized.

@molobrakos

molobrakos Dec 14, 2018

Collaborator

Ok

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Thanks!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Dec 14, 2018

Can be merged when build passes.

@balloob balloob merged commit 0041797 into home-assistant:dev Dec 14, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 92.909%
Details

@wafflebot wafflebot bot removed the in progress label Dec 14, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 14, 2018

Merge branch 'dev' into current
* dev: (88 commits)
  huawei_lte: Fetch only required data (home-assistant#17618)
  Adding support for Plum Lightpad (home-assistant#16576)
  Fix restore state for manual alarm control panel (home-assistant#19284)
  Set InsteonEntity name to be combo of description and address. (home-assistant#17262)
  Device config for Fibaro hub integration (home-assistant#19171)
  Add air pollutants component (home-assistant#18707)
  Updated ELIQ Online sensor to async API (home-assistant#19248)
  Set unavailable when unreachable (home-assistant#19012)
  Make variable `entity_id` available to value_template for MQTT binary sensor (home-assistant#19195)
  home-assistant#17333: update to use DOMAIN constants and standards. (home-assistant#19242)
  Fix race in entity_platform.async_add_entities (home-assistant#19222)
  Fix race in entity_platform.async_add_entities (home-assistant#19222)
  Bumped version to 0.84.2
  Fix call to super() (home-assistant#19279)
  Fix OwnTracks deadlocking (home-assistant#19260)
  Fix list (fixes home-assistant#19235) (home-assistant#19258)
  Add automation and script events to logbook filter events (home-assistant#19253)
  Bump aioasuswrt (home-assistant#19229)
  Review comments
  Move check to websocket
  ...

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Updated ELIQ Online sensor to async API (home-assistant#19248)
* Updated ELIQ Online sensor to async API

* Remove use of STATE_UNKNOWN

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment