New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OwnTracks deadlocking #19260

Merged
merged 2 commits into from Dec 13, 2018

Conversation

Projects
None yet
4 participants
@balloob
Copy link
Member

balloob commented Dec 13, 2018

Description:

When people had manually configured the owntracks platform, we got a circular dependency and deadlock.

Example entry for configuration.yaml (if applicable):

device_tracker:
  platform: owntracks

# owntracks config entry.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.84.2 milestone Dec 13, 2018

@balloob balloob merged commit 34cfdb4 into dev Dec 13, 2018

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/push The Travis CI build passed
Details

@delete-merged-branch delete-merged-branch bot deleted the fix-owntracks-deadlock branch Dec 13, 2018

@wafflebot wafflebot bot removed the in progress label Dec 13, 2018

balloob added a commit that referenced this pull request Dec 14, 2018

Fix OwnTracks deadlocking (#19260)
* Fix OwnTracks deadlocking

* Fix deadlock

@balloob balloob referenced this pull request Dec 14, 2018

Merged

0.84.2 #19281

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 14, 2018

Merge branch 'dev' into current
* dev: (88 commits)
  huawei_lte: Fetch only required data (home-assistant#17618)
  Adding support for Plum Lightpad (home-assistant#16576)
  Fix restore state for manual alarm control panel (home-assistant#19284)
  Set InsteonEntity name to be combo of description and address. (home-assistant#17262)
  Device config for Fibaro hub integration (home-assistant#19171)
  Add air pollutants component (home-assistant#18707)
  Updated ELIQ Online sensor to async API (home-assistant#19248)
  Set unavailable when unreachable (home-assistant#19012)
  Make variable `entity_id` available to value_template for MQTT binary sensor (home-assistant#19195)
  home-assistant#17333: update to use DOMAIN constants and standards. (home-assistant#19242)
  Fix race in entity_platform.async_add_entities (home-assistant#19222)
  Fix race in entity_platform.async_add_entities (home-assistant#19222)
  Bumped version to 0.84.2
  Fix call to super() (home-assistant#19279)
  Fix OwnTracks deadlocking (home-assistant#19260)
  Fix list (fixes home-assistant#19235) (home-assistant#19258)
  Add automation and script events to logbook filter events (home-assistant#19253)
  Bump aioasuswrt (home-assistant#19229)
  Review comments
  Move check to websocket
  ...
@raccettura

This comment has been minimized.

Copy link
Contributor

raccettura commented Dec 14, 2018

Tried this but there might still be a problem. I've now got owntracks working with the http webhook. If I remove my device from known_devices.yml it will re-add itself.

I then tried adding the following to my config:

owntracks:
  max_gps_accuracy: 150
  waypoints: true
  events_only: true
  waypoint_whitelist:
    - raccettura
  region_mapping:
    home: home
    work: work

Then restarted and made owntracks update my location. No device was added to known_devices.yml. Accuracy was +/- 65m... which is well under 150 I'm specifying. I even upped it to 200.

Remove the config and once again I get a device added to known_devices.yml.

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Fix OwnTracks deadlocking (home-assistant#19260)
* Fix OwnTracks deadlocking

* Fix deadlock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment