New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check admin permission before able to manage config entries #19265

Merged
merged 2 commits into from Dec 14, 2018

Conversation

Projects
None yet
3 participants
@balloob
Copy link
Member

balloob commented Dec 13, 2018

Description:

Check that a user is part of the admin group before allowing changes to config entries.

We'll need to add such checks to all config APIs.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from home-assistant/core as a code owner Dec 13, 2018

@wafflebot wafflebot bot added the in progress label Dec 13, 2018

Show resolved Hide resolved tests/components/config/test_config_entries.py Outdated
Show resolved Hide resolved tests/components/config/test_config_entries.py Outdated
Show resolved Hide resolved tests/components/config/test_config_entries.py Outdated
Show resolved Hide resolved tests/components/config/test_config_entries.py Outdated
Show resolved Hide resolved tests/components/config/test_config_entries.py Outdated

@balloob balloob merged commit a5a896b into dev Dec 14, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.0006%) to 92.887%
Details

@delete-merged-branch delete-merged-branch bot deleted the admin-perm-config-entries branch Dec 14, 2018

@wafflebot wafflebot bot removed the in progress label Dec 14, 2018

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment