New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename is_owner decorator to is_admin #19266

Merged
merged 2 commits into from Dec 14, 2018

Conversation

Projects
None yet
2 participants
@balloob
Copy link
Member

balloob commented Dec 13, 2018

Description:

Rename require_owner decorator to require_admin and check for admin permissions instead of is_owner.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob merged commit 4f98818 into dev Dec 14, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0005%) to 92.888%
Details

@delete-merged-branch delete-merged-branch bot deleted the rename-is-owner-decorator branch Dec 14, 2018

@wafflebot wafflebot bot removed the in progress label Dec 14, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Rename is_owner decorator to is_admin (home-assistant#19266)
* Rename is_owner decorator to is_admin

* Update test_auth.py

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment