New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for entur sensor exception during setup with quay only config #19267

Merged
merged 1 commit into from Dec 14, 2018

Conversation

Projects
None yet
4 participants
@hfurubotten
Copy link
Contributor

hfurubotten commented Dec 13, 2018

Description:

Upgraded enturclient to 0.1.2 which has fix for an exception raised during setup when only *:Quay:* stop ids are given in default config.

(Temporary fix has been setting expand_platforms: false in config. )

Related issue (if applicable): fixes #19232

Example entry for configuration.yaml (if applicable):

# This config fails, but will be fixed now. 
- platform: entur_public_transport
  expand_platforms: true
  stop_ids:
    - 'NSR:Quay:12089'
    - 'NSR:Quay:11976'

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@hfurubotten hfurubotten force-pushed the hfurubotten:entur-upgrade branch from f87186e to 29566fc Dec 13, 2018

@Danielhiversen Danielhiversen merged commit ddbfdf1 into home-assistant:dev Dec 14, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on entur-upgrade at 92.884%
Details

@wafflebot wafflebot bot removed the in progress label Dec 14, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment