New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synology chat add verify ssl #19276

Merged
merged 2 commits into from Dec 14, 2018

Conversation

Projects
None yet
3 participants
@bremor
Copy link
Contributor

bremor commented Dec 13, 2018

Description:

Added verify_ssl option into synology_chat to allow users to disable ssl verification for self signed certs or direct IP address in the url.

Related issue (if applicable): fixes # Not applicable

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7833

Example entry for configuration.yaml (if applicable):

notify:
  - platform: synology_chat
    name: hass_synchat
    verify_ssl: True
    resource: https://example.your.synology.com/webapi/entry.cgi?api=SYNO.Chat.External&method=incoming&version=1&token=ABCDEFG

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

bremor added some commits Dec 13, 2018

Added verify_ssl option to notify.synology_chat
Python requests will verify ssl by default, this configuration options allows the user to specify if they want to verify ssl or not. Non breaking change, default is True - do verify ssl.
@fabaff

fabaff approved these changes Dec 14, 2018

Copy link
Member

fabaff left a comment

Thanks 🐦

@fabaff fabaff merged commit 74a93fe into home-assistant:dev Dec 14, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.009%) to 92.884%
Details

@wafflebot wafflebot bot removed the in progress label Dec 14, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Synology chat add verify ssl (home-assistant#19276)
* Update synology_chat.py

* Added verify_ssl option to notify.synology_chat

Python requests will verify ssl by default, this configuration options allows the user to specify if they want to verify ssl or not. Non breaking change, default is True - do verify ssl.

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment