New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call to super() #19279

Merged
merged 3 commits into from Dec 14, 2018

Conversation

@marchingphoenix
Copy link
Contributor

marchingphoenix commented Dec 14, 2018

Description:

Fix call to super() change made in #18650

Related issue (if applicable): fixes #19273

Pull request in home-assistant.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.
    N/A

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
    Entire platform currently has no tests.
@marchingphoenix

This comment has been minimized.

Copy link
Contributor

marchingphoenix commented Dec 14, 2018

Entire platform currently has no test coverage. That's how this problem wasn't caught in the first place.
This PR is to fix the currently problem. Tests will need to be added in another PR.
I do not have these components so am unable to test.

Show resolved Hide resolved tests/components/light/test_lutron.py Outdated
Show resolved Hide resolved tests/components/light/test_lutron.py Outdated
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Thanks! Can be merged when build passes.

@MartinHjelmare MartinHjelmare added this to the 0.84.2 milestone Dec 14, 2018

@fabaff fabaff changed the title light.lutron: fix call to super() Fix call to super() Dec 14, 2018

@fabaff fabaff merged commit 377c612 into home-assistant:dev Dec 14, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.893%
Details

@wafflebot wafflebot bot removed the in progress label Dec 14, 2018

@marchingphoenix marchingphoenix deleted the marchingphoenix:lutron-fix-super-call branch Dec 14, 2018

balloob added a commit that referenced this pull request Dec 14, 2018

Fix call to super() (#19279)
* #19273: fix call to super()

* #19273: adjust to python3 standards.

* #19273: remove bad test.

@balloob balloob referenced this pull request Dec 14, 2018

Merged

0.84.2 #19281

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 14, 2018

Merge branch 'dev' into current
* dev: (88 commits)
  huawei_lte: Fetch only required data (home-assistant#17618)
  Adding support for Plum Lightpad (home-assistant#16576)
  Fix restore state for manual alarm control panel (home-assistant#19284)
  Set InsteonEntity name to be combo of description and address. (home-assistant#17262)
  Device config for Fibaro hub integration (home-assistant#19171)
  Add air pollutants component (home-assistant#18707)
  Updated ELIQ Online sensor to async API (home-assistant#19248)
  Set unavailable when unreachable (home-assistant#19012)
  Make variable `entity_id` available to value_template for MQTT binary sensor (home-assistant#19195)
  home-assistant#17333: update to use DOMAIN constants and standards. (home-assistant#19242)
  Fix race in entity_platform.async_add_entities (home-assistant#19222)
  Fix race in entity_platform.async_add_entities (home-assistant#19222)
  Bumped version to 0.84.2
  Fix call to super() (home-assistant#19279)
  Fix OwnTracks deadlocking (home-assistant#19260)
  Fix list (fixes home-assistant#19235) (home-assistant#19258)
  Add automation and script events to logbook filter events (home-assistant#19253)
  Bump aioasuswrt (home-assistant#19229)
  Review comments
  Move check to websocket
  ...

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Fix call to super() (home-assistant#19279)
* home-assistant#19273: fix call to super()

* home-assistant#19273: adjust to python3 standards.

* home-assistant#19273: remove bad test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment