New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set tradfri unavailable on communication error #19288

Merged
merged 1 commit into from Jan 11, 2019

Conversation

Projects
None yet
4 participants
@jarlebh
Copy link
Contributor

jarlebh commented Dec 14, 2018

Description:

Related issue (if applicable): fixes #17675

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@homeassistant

This comment has been minimized.

Copy link

homeassistant commented Dec 14, 2018

Hi @jarlebh,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@wafflebot wafflebot bot added the in progress label Dec 14, 2018

@homeassistant homeassistant added cla-signed and removed cla-needed labels Dec 14, 2018

@pvizeli pvizeli requested a review from lwis Dec 14, 2018

@MartinHjelmare MartinHjelmare changed the title When tradfri experience communication errors make the lights/devices … Set tradfri unavailable on communication error Dec 14, 2018

@lwis

lwis approved these changes Dec 14, 2018

@lwis

This comment has been minimized.

Copy link
Member

lwis commented Dec 14, 2018

TradfriGroup doesn't have _available defined, once that's fixed this can be merged 👍

@jarlebh jarlebh force-pushed the jarlebh:dev branch from 80e2aad to 8713465 Dec 18, 2018

@jarlebh

This comment has been minimized.

Copy link
Contributor Author

jarlebh commented Dec 18, 2018

TradfriGroup doesn't have _available defined, once that's fixed this can be merged 👍

I removed this from the group now.

@lwis

This comment has been minimized.

Copy link
Member

lwis commented Dec 19, 2018

@jarlebh we can keep _available on Group, we just need to add the same functionality that Light and Sensor already have for avaliability checking.

@balloob balloob merged commit b3a08d5 into home-assistant:dev Jan 11, 2019

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 93.027%
Details

@wafflebot wafflebot bot removed the in progress label Jan 11, 2019

@balloob balloob referenced this pull request Jan 23, 2019

Merged

0.86.0 #20354

alandtse added a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment