New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prezzibenzina (Italian Fuel Price) Sensor #19297

Merged
merged 11 commits into from Dec 18, 2018

Conversation

Projects
None yet
4 participants
@eliseomartelli
Copy link
Contributor

eliseomartelli commented Dec 14, 2018

Description:

Added the PrezziBenzina sensor platform.

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: prezzibenzina
    station: 1080
    fuel_types: "Benzina"
    name: "test"

[OR]

  - platform: prezzibenzina
    station: 1080
    fuel_types: 
        - "Benzina"
        - "GPL"
    name: "test"

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

Documentation PR: home-assistant/home-assistant.io#7843

eliseomartelli added some commits Dec 14, 2018

@eliseomartelli eliseomartelli referenced this pull request Dec 14, 2018

Merged

Add prezzibenzina documentation #7843

2 of 2 tasks complete
@fabaff
Copy link
Member

fabaff left a comment

I assume that at the moment all fuel types are returned. Would it make sense to allow an user to choose which types she/he wants?

@eliseomartelli

This comment has been minimized.

Copy link
Contributor

eliseomartelli commented Dec 15, 2018

You mean listing fuel types needed for a station?
The problem is the inconsistency between stations :(

Edit: Added the filter 👍

eliseomartelli added some commits Dec 15, 2018

@eliseomartelli

This comment has been minimized.

Copy link
Contributor

eliseomartelli commented Dec 16, 2018

Updated the documentation to reflect the newly added filter.

eliseomartelli and others added some commits Dec 18, 2018

@fabaff

fabaff approved these changes Dec 18, 2018

Copy link
Member

fabaff left a comment

Thanks 🐦

@fabaff fabaff merged commit 51e6371 into home-assistant:dev Dec 18, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 93.041%
Details

@wafflebot wafflebot bot removed the in progress label Dec 18, 2018

@eliseomartelli eliseomartelli deleted the eliseomartelli:prezzibenzina branch Dec 18, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Add Prezzibenzina (Italian Fuel Price) Sensor (home-assistant#19297)
* complete(?)

* fixed linting

* update requirements

* added to coveragerc

* fixed linting

* added ability to set custom name

* fixed linting

* added filter

* spacing

* Added list of possible fuels

* Minor updates

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment