New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add camera selection config to skybell camera #19310

Merged
merged 2 commits into from Dec 17, 2018

Conversation

Projects
None yet
4 participants
@nhorvath
Copy link
Contributor

nhorvath commented Dec 14, 2018

Description:

Ongoing conversation in #17617 resulted in a better fix. Some people liked the image we used when the original broke, so I am adding a config to let you choose which image to use in Skybell Camera.

Related issue (if applicable): fixes #17617

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7849

Example entry for configuration.yaml (if applicable):

camera:
  - platform: skybell
    monitored_conditions:
    - avatar
    - activity
    activity_name: "Last Activity"
    avatar_name: "Current"

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@nhorvath

This comment has been minimized.

Copy link
Contributor

nhorvath commented Dec 17, 2018

@MartinHjelmare this is a follow up to #19100 (review). I was able to fix the underlying issue, but added some configs to the camera so people could keep the current functionality if they wanted.

I'm pretty sure the failed test is unrelated to my change. I'm not sure how to make it rerun to see if it's just a mistake.

Show resolved Hide resolved homeassistant/components/camera/skybell.py Outdated
Show resolved Hide resolved homeassistant/components/camera/skybell.py Outdated
Show resolved Hide resolved homeassistant/components/camera/skybell.py Outdated
Show resolved Hide resolved homeassistant/components/camera/skybell.py Outdated
Show resolved Hide resolved homeassistant/components/camera/skybell.py Outdated
Show resolved Hide resolved homeassistant/components/camera/skybell.py Outdated
Show resolved Hide resolved homeassistant/components/camera/skybell.py Outdated
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Looks good! Can be merged when build passes.

@cgarwood cgarwood merged commit 6adbf3b into home-assistant:dev Dec 17, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 93.018%
Details

@wafflebot wafflebot bot removed the in progress label Dec 17, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Add camera selection config to skybell camera (home-assistant#19310)
* add camera selection config to skybell camera

* code review changes.

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

CCOSTAN added a commit to CCOSTAN/Home-AssistantConfig that referenced this pull request Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment