New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump georss_client to 0.5 #19337

Merged
merged 1 commit into from Dec 16, 2018

Conversation

Projects
None yet
3 participants
@exxamalte
Copy link
Contributor

exxamalte commented Dec 15, 2018

Description:

Version 0.5 of the georss_client library now supports Python 3.7. The previous version was depending on the feedparser library which has now been replaced with a built-in xml parser.

There is a small chance that some exotic (=non-standaard) GeoRSS feeds are not going to work with the new built-in parser, but I don't think this would justify calling this a breaking change.
All unit tests remained unchanged, i.e. the interface between the library and Home Assistant is fully compatible.

Related issue (if applicable): contributes fix to #15479

Pull request in home-assistant.io with documentation (if applicable): n/a

Example entry for configuration.yaml (if applicable): n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
@fabaff

fabaff approved these changes Dec 16, 2018

Copy link
Member

fabaff left a comment

Thanks 🐦

@fabaff fabaff merged commit 629dd24 into home-assistant:dev Dec 16, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.009%) to 92.881%
Details

@wafflebot wafflebot bot removed the in progress label Dec 16, 2018

@exxamalte exxamalte deleted the exxamalte:georss_client_update branch Dec 16, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment