New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not being able to update entities #19344

Merged
merged 1 commit into from Dec 16, 2018

Conversation

Projects
None yet
5 participants
@glentakahashi
Copy link
Contributor

glentakahashi commented Dec 16, 2018

Description:

When editing an entity in the frontend dialog, pressing save causes a "save failed: Entity is already registered" error. This is because the frontend always sets name and new_entity_id in the websocket command even if they haven't been changed. This adds a check that the new_entity_id is actually different from entity_id before erroring that the new_entity_id is already registered.

Related issue (if applicable): fixes #

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
Fix not being able to update entities
When editing an entity in the frontend dialog, pressing save causes a "save failed: Entity is already registered" error. This is because the frontend always sets `name` and `new_entity_id` in the websocket command even if they haven't been changed. This adds a check that the `new_entity_id` is actually different from `entity_id` before erroring that the `new_entity_id` is already registered.
@emontnemery

This comment has been minimized.

Copy link
Contributor

emontnemery commented Dec 16, 2018

This is a regression caused by #19194 and the fix looks good.
The PR should be against dev branch though, not against master.
@glentakahashi Since it would be very nice to have this fixed and merged, I opened #19346 which is your fix, but against dev branch.

@emontnemery emontnemery referenced this pull request Dec 16, 2018

Closed

Fix not being able to update entities #19346

3 of 3 tasks complete

@wafflebot wafflebot bot removed the in progress label Dec 16, 2018

@balloob balloob changed the base branch from master to dev Dec 16, 2018

@balloob balloob reopened this Dec 16, 2018

@wafflebot wafflebot bot added the in progress label Dec 16, 2018

@balloob

This comment has been minimized.

Copy link
Member

balloob commented Dec 16, 2018

@emontnemery we can just change branch by clicking the edit button at the top 👍

@balloob balloob added this to the 0.84.3 milestone Dec 16, 2018

@emontnemery

This comment has been minimized.

Copy link
Contributor

emontnemery commented Dec 16, 2018

@balloob thanks!
Edit: Description updated to remove some irrelevant checklist items

@cgarwood cgarwood merged commit b031ded into home-assistant:dev Dec 16, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on patch-1 at 92.881%
Details

@wafflebot wafflebot bot removed the in progress label Dec 16, 2018

@glentakahashi glentakahashi deleted the glentakahashi:patch-1 branch Dec 16, 2018

balloob added a commit that referenced this pull request Dec 17, 2018

Fix not being able to update entities (#19344)
When editing an entity in the frontend dialog, pressing save causes a "save failed: Entity is already registered" error. This is because the frontend always sets `name` and `new_entity_id` in the websocket command even if they haven't been changed. This adds a check that the `new_entity_id` is actually different from `entity_id` before erroring that the `new_entity_id` is already registered.

@balloob balloob referenced this pull request Dec 17, 2018

Merged

0.84.3 #19391

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 22, 2018

Merge branch 'dev' into current
* dev: (22 commits)
  Update yale smart alarm client to v0.1.6 (home-assistant#19495)
  Add deprecation warning (home-assistant#19515)
  Restore state for zha binary_sensors on restart. (home-assistant#19314)
  Add ZHA battery sensor (home-assistant#19363)
  Clean up RFLink tests and add two tests (home-assistant#19511)
  Allow scrape sensor to retry setting up platform if initial setup fails (home-assistant#19498)
  Add Lutron Homeworks component (home-assistant#18311)
  Disable creating port mappings from UI, add discovery from component (home-assistant#18565)
  Bumped version to 0.84.6
  Remove check if base url is local (home-assistant#19494)
  Remove check if base url is local (home-assistant#19494)
  Bumped version to 0.84.5
  Bump pyharmony (home-assistant#19460)
  Bumped version to 0.84.4
  Use web sockets for Harmony HUB (home-assistant#19440)
  Fix IHC config schema (home-assistant#19415)
  Updated frontend to 20181211.2
  Bumped version to 0.84.3
  Fix not being able to update entities (home-assistant#19344)
  Fix restore state for manual alarm control panel (home-assistant#19284)
  ...

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Fix not being able to update entities (home-assistant#19344)
When editing an entity in the frontend dialog, pressing save causes a "save failed: Entity is already registered" error. This is because the frontend always sets `name` and `new_entity_id` in the websocket command even if they haven't been changed. This adds a check that the `new_entity_id` is actually different from `entity_id` before erroring that the `new_entity_id` is already registered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment