New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide charging indicator for mychevy #19348

Merged
merged 2 commits into from Dec 17, 2018

Conversation

Projects
None yet
4 participants
@sdague
Copy link
Member

sdague commented Dec 16, 2018

This expands the mychevy sensor for the battery level to also know if
the system is currently charging to get the correct icon.

Description:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
Provide charging indicator for mychevy
This expands the mychevy sensor for the battery level to also know if
the system is currently charging to get the correct icon.
Show resolved Hide resolved homeassistant/components/sensor/mychevy.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/mychevy.py Outdated
@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Dec 17, 2018

Nice! Can be merged when build passes.

@cgarwood cgarwood merged commit e9c1946 into home-assistant:dev Dec 17, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on mychevy_charging at 93.018%
Details

@wafflebot wafflebot bot removed the in progress label Dec 17, 2018

@sdague

This comment has been minimized.

Copy link
Member

sdague commented Dec 18, 2018

Thanks!

@sdague sdague deleted the sdague:mychevy_charging branch Dec 18, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Provide charging indicator for mychevy (home-assistant#19348)
* Provide charging indicator for mychevy

This expands the mychevy sensor for the battery level to also know if
the system is currently charging to get the correct icon.

* address review feedback

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment