New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken deprecation message #19349

Merged
merged 1 commit into from Dec 16, 2018

Conversation

Projects
None yet
4 participants
@emontnemery
Copy link
Contributor

emontnemery commented Dec 16, 2018

Description:

Fix broken check for deprecated json_attributes configuration variable.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@wafflebot wafflebot bot added the in progress label Dec 16, 2018

@emontnemery emontnemery merged commit 07e3843 into home-assistant:dev Dec 16, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on mqtt_sensor_json_attributes_topic_fix at 92.889%
Details

@wafflebot wafflebot bot removed the in progress label Dec 16, 2018

@emontnemery emontnemery deleted the emontnemery:mqtt_sensor_json_attributes_topic_fix branch Dec 19, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

@tyjtyj

This comment has been minimized.

Copy link

tyjtyj commented Jan 10, 2019

anyway to put an example for json_attributes_topic if it behave different from json_attributes

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Jan 10, 2019

Please open an issue if you suspect a bug. If you need help please use our help channels:
https://home-assistant.io/help/#communication-channels

Merged PRs should not be used for support or bug reports. Thanks!

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Jan 10, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.