New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openSenseMap air pollutants platform #19357

Merged
merged 3 commits into from Dec 18, 2018

Conversation

Projects
None yet
5 participants
@fabaff
Copy link
Member

fabaff commented Dec 16, 2018

Description:

Support for air pollutants data from openSenseMap.

Example entry for configuration.yaml (if applicable):

air_pollutants:
  - platform: opensensemap
    station_id: 5bb9e7a3043f3f001b1fa7b3

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

We can add a SCAN_INTERVAL constant set to the same interval as min time between updates constant.


if name is None:
if 'name' not in osm_api.api.data:
_LOGGER.error("Station %s is not available", station_id)

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Dec 17, 2018

Member

Is this error not possible if we provide a name in the config?

@fabaff

This comment has been minimized.

Copy link
Member

fabaff commented Dec 18, 2018

Docs: home-assistant/home-assistant.io@1afe322 (no, PR sorry)

@fabaff fabaff merged commit 9c8e109 into dev Dec 18, 2018

6 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.881%
Details

@wafflebot wafflebot bot removed the in progress label Dec 18, 2018

@delete-merged-branch delete-merged-branch bot deleted the opensensemap branch Dec 18, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Add openSenseMap air pollutants platform (home-assistant#19357)
* Add openSenseMap air pollutants platform

* Fix issues (Docstring, log entries and check)

* Use SCAN_INTERVAL and name handling
@RualdOrdelman

This comment has been minimized.

Copy link

RualdOrdelman commented Dec 31, 2018

Wow nice integration. Thanks for the great work.

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment