New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove recorder purge protection #19358

Merged
merged 1 commit into from Dec 16, 2018

Conversation

Projects
None yet
4 participants
@amelchio
Copy link
Member

amelchio commented Dec 16, 2018

Description:

Since #17270 we no longer need to protect the latest state of each entity when purging the recorder database.

Related issue (if applicable): fixes #14046

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@OttoWinter

This comment has been minimized.

Copy link
Contributor

OttoWinter commented Dec 16, 2018

Am I right in thinking that this could significantly speed up recorder purges?

(Context: the recorder purges are taking ages with my MySQL db; but when I execute them manually (without the state protection), it's much quicker)

@pvizeli pvizeli merged commit f9c0288 into home-assistant:dev Dec 16, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.002%) to 93.008%
Details

@wafflebot wafflebot bot removed the in progress label Dec 16, 2018

@amelchio

This comment has been minimized.

Copy link
Member

amelchio commented Dec 17, 2018

@OttoWinter I think it will but I did not benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment