New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in ZHA light #19368

Merged
merged 6 commits into from Dec 23, 2018

Conversation

Projects
None yet
4 participants
@dmulcahey
Copy link
Contributor

dmulcahey commented Dec 17, 2018

This PR sets up attribute reporting on the on/off and level control clusters for lights. It addresses several state issues when controlling the smart bulbs from a wall switch. When complete fixes: #15379, fixes #11782, fixes #14804

Show resolved Hide resolved homeassistant/components/light/zha.py Outdated
Show resolved Hide resolved homeassistant/components/light/zha.py Outdated

@dmulcahey dmulcahey closed this Dec 18, 2018

@dmulcahey dmulcahey reopened this Dec 18, 2018

@wafflebot wafflebot bot added in progress and removed in progress labels Dec 18, 2018

@dmulcahey dmulcahey force-pushed the dmulcahey:dm/zha-light-fixes branch from e464cc0 to a0fe117 Dec 19, 2018

@dmulcahey dmulcahey changed the title WIP - fix issues in ZHA light Fix issues in ZHA light Dec 19, 2018

@dmulcahey dmulcahey changed the title Fix issues in ZHA light Fix issues in ZHA light Dec 20, 2018

@dmulcahey dmulcahey changed the title Fix issues in ZHA light Fix issues in ZHA light Dec 20, 2018

dmulcahey added some commits Dec 16, 2018

@dmulcahey dmulcahey force-pushed the dmulcahey:dm/zha-light-fixes branch from a0fe117 to e51c58b Dec 22, 2018

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Good! Can be merged when build passes.

@dmulcahey

This comment has been minimized.

Copy link
Contributor

dmulcahey commented Dec 23, 2018

@MartinHjelmare looks like we’re good!

@MartinHjelmare MartinHjelmare merged commit 50888ae into home-assistant:dev Dec 23, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0008%) to 93.031%
Details

@wafflebot wafflebot bot removed the in progress label Dec 23, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Fix issues in ZHA light (home-assistant#19368)
* make light report on/off and level

* refactoring and review comments

* refactor

* use boolean for set_state - review comment

* async_schedule_update_ha_state() on level change - review comment

* fix docstring - review comment

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 25, 2018

Merge branch 'dev' into current
* dev: (27 commits)
  Add device_id configuration option to Bluetooth tracker (home-assistant#18539)
  Add homematicip cloud full flush measuring switch (home-assistant#19247)
  Added support for triggered state on NX584 alarm. (home-assistant#19524)
  Add HomematicIP SMI55 device (home-assistant#19400)
  Clean up homematicip cloud (home-assistant#19481)
  Improve Lutron RadioRA2 support, adding switches and scenes (home-assistant#18330)
  Remove global from ZHA application controller (home-assistant#19557)
  Update homekit controller to homekit==0.12.0 (home-assistant#19549)
  Improve handling of MQTT light discovery (home-assistant#19436)
  Fix support for base topic for empty values in MQTT discovery msg (home-assistant#19501)
  Configure ZHA entity on new ZHA device join (home-assistant#19470)
  Add hub- and device-info for tellduslive (home-assistant#19180)
  Fix issues in ZHA light (home-assistant#19368)
  Updated to support per device find iphone sound. (home-assistant#19535)
  Change ISY binary_sensor subnode to hex (home-assistant#19471)
  increase robustness, when something upstream fails (home-assistant#19493)
  Support ZHA light turn_off transition (home-assistant#19531)
  Pywemo version bump (home-assistant#19538)
  Make ZHA entities non-polled by default (home-assistant#19536)
  Add ZHA occupancy sensor (home-assistant#19365)
  ...

@dmulcahey dmulcahey deleted the dmulcahey:dm/zha-light-fixes branch Dec 26, 2018

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment