New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pencom #19369

Merged
merged 4 commits into from Dec 26, 2018

Conversation

Projects
None yet
3 participants
@dubnom
Copy link
Contributor

dubnom commented Dec 17, 2018

Description:

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable):
home-assistant/home-assistant.io#7879

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

dubnom added some commits Dec 12, 2018

@wafflebot wafflebot bot added the in progress label Dec 17, 2018

@dubnom dubnom referenced this pull request Dec 17, 2018

Merged

Pencom #7879

2 of 2 tasks complete
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Looks good. Two small things.

})


def setup_platform(hass, config, add_devices, discovery_info=None):

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Dec 25, 2018

Member

Rename add_devices to add_entities.

@property
def device_state_attributes(self):
"""Return supported attributes."""
return {"Board": self._board,

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Dec 25, 2018

Member

State attribute keys should be lowercase snakecase.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Dec 25, 2018

Please add a link to a docs PR in the PR description.

@MartinHjelmare MartinHjelmare merged commit 6f99437 into home-assistant:dev Dec 26, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 93.045%
Details

@wafflebot wafflebot bot removed the in progress label Dec 26, 2018

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment