New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast lametric cycles parameter to int #19370

Merged
merged 1 commit into from Dec 17, 2018

Conversation

Projects
None yet
3 participants
@jumpkick
Copy link
Contributor

jumpkick commented Dec 17, 2018

Description:

Whenever cycles is specified in a lametric data block, it is captured as a string and fed to the lametric python module as such. The lmnotify python package expects cycles to be an integer value, so the assertion fails, the notification is not sent, and the following appears in the log:

  File "/usr/lib/python3.6/site-packages/lmnotify/models.py", line 121, in __init__
    assert(cycles >= 0)
TypeError: '>=' not supported between instances of 'str' and 'int'

Related issue (if applicable): fixes #14908

@wafflebot wafflebot bot added the in progress label Dec 17, 2018

@fabaff fabaff changed the title * Cast lametric cycles parameter to int to fix #14908 Cast lametric cycles parameter to int to fix #14908 Dec 17, 2018

@fabaff fabaff changed the title Cast lametric cycles parameter to int to fix #14908 Cast lametric cycles parameter to int (fixes #14908) Dec 17, 2018

@MartinHjelmare MartinHjelmare changed the title Cast lametric cycles parameter to int (fixes #14908) Cast lametric cycles parameter to int Dec 17, 2018

@MartinHjelmare MartinHjelmare merged commit f1005d3 into home-assistant:dev Dec 17, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.026%
Details

@wafflebot wafflebot bot removed the in progress label Dec 17, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

@jumpkick jumpkick deleted the jumpkick:fix_14908 branch Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment