New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device_info to Daikin #19372

Merged
merged 2 commits into from Dec 19, 2018

Conversation

Projects
None yet
3 participants
@fredrike
Copy link
Contributor

fredrike commented Dec 17, 2018

Description:

Adds device_info for Daikin

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Looks good! Can be merged when build passes.

@fredrike

This comment has been minimized.

Copy link
Contributor

fredrike commented Dec 19, 2018

I'm not sure why the cov test breaks, it is not related to this changes..

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Dec 19, 2018

That test is flaky.

@MartinHjelmare MartinHjelmare merged commit e548772 into home-assistant:dev Dec 19, 2018

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA

@wafflebot wafflebot bot removed the in progress label Dec 19, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Add device_info to Daikin (home-assistant#19372)
* add device_info to Daikin

* Use the constant CONNECTION_NETWORK_MAC from the device registry helper.

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment