New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade youtube_dl to 2018.12.17 #19378

Merged
merged 1 commit into from Dec 17, 2018

Conversation

Projects
None yet
4 participants
@fabaff
Copy link
Member

fabaff commented Dec 17, 2018

Description

Changelog: https://github.com/rg3/youtube-dl/blob/master/ChangeLog

Tested with the following configuration:

media_extractor:

Service call:

{  
   "entity_id":"media_player.mpd",
   "media_content_id":"https://www.youtube.com/watch?v=PA_m-ppThPM",
   "media_content_type":"music"
}

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
@OttoWinter
Copy link
Contributor

OttoWinter left a comment

Tried successfully with my local install

@Danielhiversen Danielhiversen merged commit 6b8835b into dev Dec 17, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.009%) to 93.018%
Details

@wafflebot wafflebot bot removed the in progress label Dec 17, 2018

@delete-merged-branch delete-merged-branch bot deleted the upgrade-youtube_dl branch Dec 17, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment