New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESPHome Native API Restore Entities on startup #19379

Merged
merged 2 commits into from Dec 17, 2018

Conversation

Projects
None yet
4 participants
@OttoWinter
Copy link
Contributor

OttoWinter commented Dec 17, 2018

Description:

This brings back a nice feature that existed in the MQTT discovery protocol: Entities are re-created even if the ESP is not reachable. So lovelace & co don't freak out when an entity is missing.

They will be shown as unavailable as long as they're not reachable.

This creates a separate Store for each config entry. I also have code that has a global store that's shared between all config entries, but that's not as nice because it breaks the abstraction of "all config entries don't need to know about each other" (and the code is a bit less nice).

The store is only updated on successful login. So usually around once every few days (or hours, depending on WiFi signal). That shouldn't be an issue for the FS.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@OttoWinter OttoWinter merged commit 77e4f69 into home-assistant:dev Dec 17, 2018

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Hound 1 violation found.
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA

@wafflebot wafflebot bot removed the in progress label Dec 17, 2018

@OttoWinter OttoWinter deleted the OttoWinter:esphome-store branch Dec 17, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment