New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade TwitterAPI to 2.5.7 #19382

Merged
merged 1 commit into from Dec 17, 2018

Conversation

Projects
None yet
4 participants
@fabaff
Copy link
Member

fabaff commented Dec 17, 2018

Description:

Changelog: https://github.com/geduldig/TwitterAPI/blob/master/CHANGES.txt

Also, updates the Direct message feature

Example entry for configuration.yaml (if applicable):

notify:
  - platform: twitter
    name: twitter
    consumer_key: !secret twitter_consumer_key
    consumer_secret: !secret twitter_consumer_secret
    access_token: !secret twitter_access_token
    access_token_secret: !secret twitter_token_secret

Message sent with "Call Service"

{
  "message": "The sun is {% if is_state('sun.sun', 'above_horizon') %}up{% else %}down{% endif %}! A  TwitterAPI update for @home_assistant."
}

馃槃 -> 鈸傦笍

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • [x New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@wafflebot wafflebot bot added the in progress label Dec 17, 2018

@pvizeli pvizeli merged commit 90608da into dev Dec 17, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.026%
Details

@delete-merged-branch delete-merged-branch bot deleted the upgrade-TwitterAPI branch Dec 17, 2018

@wafflebot wafflebot bot removed the in progress label Dec 17, 2018

'media_ids': media_id})
user_resp = self.api.request(
'users/lookup', {'screen_name': self.user})
user_id = user_resp.json()[0]['id']

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Dec 17, 2018

Member

Is this safe even if the response is not 200?

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment