New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade requests to 2.21.0 #19385

Merged
merged 1 commit into from Dec 18, 2018

Conversation

Projects
None yet
3 participants
@fabaff
Copy link
Member

fabaff commented Dec 17, 2018

Description:

Changelog: https://github.com/requests/requests/blob/master/HISTORY.md#2210-2018-12-10

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@fabaff fabaff requested a review from home-assistant/core as a code owner Dec 17, 2018

@wafflebot wafflebot bot added the in progress label Dec 17, 2018

setup.py Outdated
@@ -38,8 +38,8 @@
'attrs==18.2.0',
'bcrypt==3.1.4',
'certifi>=2018.04.16',
# Dec 5, 2018: Idna released 2.8, requests caps idna at <2.8, CI fails
'idna==2.7',
# Dec 17, 2018: Idna released 2.8, requests 2.21.0 is pinning idna

This comment has been minimized.

@balloob

balloob Dec 17, 2018

Member

If requests can work with the newer idna, we should remove our pinning completely.

This comment has been minimized.

@fabaff

fabaff Dec 17, 2018

Member

requests wants 'idna>=2.5,<2.9'.

This comment has been minimized.

@balloob

balloob Dec 17, 2018

Member

So shall we drop our pinning then ? We only added it because the newer requests could not work with it but it somehow got installed.

This comment has been minimized.

@fabaff

fabaff Dec 18, 2018

Member

Ok, let's remove it. In a worst case scenario we would need to add it again.

@fabaff fabaff closed this Dec 18, 2018

@fabaff fabaff force-pushed the upgrade-requests branch from c260689 to 686a856 Dec 18, 2018

@wafflebot wafflebot bot removed the in progress label Dec 18, 2018

@fabaff fabaff reopened this Dec 18, 2018

@wafflebot wafflebot bot added the in progress label Dec 18, 2018

@balloob balloob merged commit c0ae7b1 into dev Dec 18, 2018

5 checks passed

WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.009%) to 93.033%
Details

@wafflebot wafflebot bot removed the in progress label Dec 18, 2018

@delete-merged-branch delete-merged-branch bot deleted the upgrade-requests branch Dec 18, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

@reaper7 reaper7 referenced this pull request Jan 10, 2019

Closed

Update requests to 2.21.0 #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment