New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump pydaikin #19388

Merged
merged 2 commits into from Dec 17, 2018

Conversation

Projects
None yet
4 participants
@fredrike
Copy link
Contributor

fredrike commented Dec 17, 2018

Description:

Pydaikin have a new version. Fixes support for devices with fan rate but not fan direction.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
@@ -22,7 +22,7 @@
ATTR_TEMPERATURE, CONF_HOST, CONF_NAME, TEMP_CELSIUS)
import homeassistant.helpers.config_validation as cv

REQUIREMENTS = ['pydaikin==0.8']
REQUIREMENTS = ['pydaikin==0.9']

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Dec 17, 2018

Member

The platform shouldn't have the requirements when there is a component. This should be removed.

This comment has been minimized.

@fredrike

fredrike Dec 17, 2018

Contributor

There is always something to pick on 😏

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Can be merged when build passes.

@cgarwood cgarwood merged commit 0ab9e33 into home-assistant:dev Dec 17, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.026%
Details

@wafflebot wafflebot bot removed the in progress label Dec 17, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Version bump pydaikin (home-assistant#19388)
* version bump pydaikin

* remove requirements from platform

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment