Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for multiple Netatmo thermostats/valves #19407

Merged
merged 14 commits into from Mar 3, 2019

Conversation

Projects
None yet
9 participants
@shanbs
Copy link
Contributor

shanbs commented Dec 17, 2018

Description:

Added support for Netatmo Multiple thermostats/valves.

Related issue (if applicable): fixes #
#14818
#16330

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7884

Example entry for configuration.yaml (if applicable):

climate:
  platform: netatmo
  homes:
    - name: home1_name
      rooms:
        - room1_name
        - room2_name
    - name: home2_name
      rooms:
        - room3_name
        - room4_name

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@wafflebot wafflebot bot added the in progress label Dec 17, 2018

@shanbs shanbs referenced this pull request Dec 17, 2018

Merged

Supporting for multiple Netatmo thermostates/valves #7884

2 of 2 tasks complete

@fabaff fabaff changed the title climate/netatmo: Added support for multiple thermostats/valves Added support for multiple Netatmo thermostats/valves Dec 17, 2018

@shanbs shanbs closed this Jan 28, 2019

@shanbs shanbs reopened this Jan 28, 2019

@wafflebot wafflebot bot added in progress and removed in progress labels Jan 28, 2019

@shanbs shanbs closed this Jan 29, 2019

@shanbs shanbs reopened this Jan 29, 2019

@wafflebot wafflebot bot added in progress and removed in progress labels Jan 29, 2019

@ioangogo

This comment has been minimized.

Copy link
Contributor

ioangogo commented Feb 9, 2019

this PR now has conflicts due to changes, AFAIK it seems to be battery percentages being added that have caused this

@shanbs

This comment has been minimized.

Copy link
Contributor Author

shanbs commented Feb 10, 2019

this PR now has conflicts due to changes, AFAIK it seems to be battery percentages being added that have caused this

Thanks for reminding. I think it was due to #20677, I fetched the changes and rebased.

@shanbs shanbs closed this Feb 10, 2019

@wafflebot wafflebot bot removed the in progress label Feb 10, 2019

@shanbs shanbs reopened this Feb 10, 2019

@wafflebot wafflebot bot added the in progress label Feb 10, 2019

@esseki

esseki approved these changes Feb 17, 2019

@shanbs

This comment has been minimized.

Copy link
Contributor Author

shanbs commented Feb 17, 2019

@esseki Thanks for approving. After that, I resolved the conflicts, is a second review required?

@shanbs shanbs closed this Feb 27, 2019

@shanbs shanbs reopened this Feb 27, 2019

@wafflebot wafflebot bot added in progress and removed in progress labels Feb 27, 2019

@rohankapoorcom
Copy link
Member

rohankapoorcom left a comment

A couple more changes, but this is looking great!

Show resolved Hide resolved homeassistant/components/netatmo/climate.py Outdated
Show resolved Hide resolved homeassistant/components/netatmo/climate.py
Show resolved Hide resolved homeassistant/components/netatmo/climate.py Outdated
@rohankapoorcom
Copy link
Member

rohankapoorcom left a comment

Can be merged once build passes! Great work!

@shanbs

This comment has been minimized.

Copy link
Contributor Author

shanbs commented Mar 1, 2019

Can be merged once build passes! Great work!

Thanks to you!

@rohankapoorcom rohankapoorcom merged commit 18372ad into home-assistant:dev Mar 3, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.001%) to 92.748%
Details

@wafflebot wafflebot bot removed the in progress label Mar 3, 2019

@cogneato

This comment has been minimized.

Copy link

cogneato commented Mar 19, 2019

Can you provide how this is a breaking change and what the user needs to do to address it?

@shanbs

This comment has been minimized.

Copy link
Contributor Author

shanbs commented Mar 19, 2019

Can you provide how this is a breaking change and what the user needs to do to address it?

  1. The format in the configuration.yaml has been changed.
  2. Add support of operation modes: auto, manual, eco, heat, cool, and off.
  3. Add support of multiple thermostat(s) and/or valve(s).
  4. Add support of multiple homes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.