New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IHC config schema #19415

Merged
merged 5 commits into from Dec 18, 2018

Conversation

Projects
None yet
6 participants
@mopolus
Copy link
Contributor

mopolus commented Dec 17, 2018

Description:

Update to fix issue 19353

Related issue (if applicable): fixes #19353

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7885

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

mopolus added some commits Dec 17, 2018

Update __init__.py
Update "unit" -> "unit_of_measurement" and configuration (from plural to singular)
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Remove the extra=vol.ALLOW_EXTRA argument from the schemas except for the main component config schema.

@MartinHjelmare MartinHjelmare changed the title Fix for #19353 Fix IHC config schema Dec 17, 2018

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Good! Thanks for the quick fix. Can be merged when build passes.

@MartinHjelmare MartinHjelmare added this to the 0.84.4 milestone Dec 17, 2018

@fabaff fabaff merged commit c59e049 into home-assistant:dev Dec 18, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on fix-for-#19353 at 93.041%
Details

@wafflebot wafflebot bot removed the in progress label Dec 18, 2018

balloob added a commit that referenced this pull request Dec 19, 2018

Fix IHC config schema (#19415)
* Update __init__.py

Update "unit" -> "unit_of_measurement" and configuration (from plural to singular)

* Update __init__.py

* Removing vol.ALLOW_EXTRA arguments

* Update __init__.py

@balloob balloob referenced this pull request Dec 19, 2018

Merged

0.84.4 #19459

@mopolus mopolus referenced this pull request Dec 20, 2018

Closed

Fix IHC config schema #7911

2 of 2 tasks complete

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 22, 2018

Merge branch 'dev' into current
* dev: (22 commits)
  Update yale smart alarm client to v0.1.6 (home-assistant#19495)
  Add deprecation warning (home-assistant#19515)
  Restore state for zha binary_sensors on restart. (home-assistant#19314)
  Add ZHA battery sensor (home-assistant#19363)
  Clean up RFLink tests and add two tests (home-assistant#19511)
  Allow scrape sensor to retry setting up platform if initial setup fails (home-assistant#19498)
  Add Lutron Homeworks component (home-assistant#18311)
  Disable creating port mappings from UI, add discovery from component (home-assistant#18565)
  Bumped version to 0.84.6
  Remove check if base url is local (home-assistant#19494)
  Remove check if base url is local (home-assistant#19494)
  Bumped version to 0.84.5
  Bump pyharmony (home-assistant#19460)
  Bumped version to 0.84.4
  Use web sockets for Harmony HUB (home-assistant#19440)
  Fix IHC config schema (home-assistant#19415)
  Updated frontend to 20181211.2
  Bumped version to 0.84.3
  Fix not being able to update entities (home-assistant#19344)
  Fix restore state for manual alarm control panel (home-assistant#19284)
  ...

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Fix IHC config schema (home-assistant#19415)
* Update __init__.py

Update "unit" -> "unit_of_measurement" and configuration (from plural to singular)

* Update __init__.py

* Removing vol.ALLOW_EXTRA arguments

* Update __init__.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment