New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various enhancements for WeMo component/platforms #19419

Merged
merged 14 commits into from Dec 19, 2018

Conversation

@sqldiablo
Copy link
Contributor

sqldiablo commented Dec 18, 2018

Description:

Various fixes & improvements to the WeMo component/platforms, including:
-- New wemo_reset_filter_life service for the WeMo Humidifier
-- Switched the remainder of the WeMo platforms to async IO
-- Removed any remaining IO in entity properties and moved them to the polling/subscription update process
-- Entity_id is now required on the wemo_set_humidity service

Breaking change:
Entity_id is now required for the wemo_set_humidity service.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7891

Example entry for configuration.yaml (if applicable):

wemo:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

sqldiablo added some commits Dec 16, 2018

WeMo - Various fixes and improvements
Various fixes & improvements to the WeMo components, including:
-- Fixes to rediscovery
-- New reset filter service for the WeMo Humidifier
-- Switched the remainder of the WeMo components to async IO
-- Removed any remaining IO in entity properties and moved them to the polling/subscription update process

@sqldiablo sqldiablo referenced this pull request Dec 18, 2018

Merged

Documentation for WeMo enhancements #7891

2 of 2 tasks complete
Show resolved Hide resolved homeassistant/components/wemo.py Outdated
Show resolved Hide resolved homeassistant/components/wemo.py Outdated
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Next time, please only have one fix or feature per PR.

Show resolved Hide resolved homeassistant/components/binary_sensor/wemo.py Outdated
Show resolved Hide resolved homeassistant/components/light/wemo.py Outdated
Show resolved Hide resolved homeassistant/components/light/wemo.py Outdated
Show resolved Hide resolved homeassistant/components/wemo.py Outdated
Show resolved Hide resolved homeassistant/components/fan/wemo.py Outdated

@fabaff fabaff changed the title WeMo component/platforms - various enhancements Various enhancements for WeMo component/platforms Dec 18, 2018

Show resolved Hide resolved homeassistant/components/fan/wemo.py Outdated
Show resolved Hide resolved homeassistant/components/fan/wemo.py Outdated
Show resolved Hide resolved homeassistant/components/fan/wemo.py Outdated

sqldiablo added some commits Dec 18, 2018

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Good!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Dec 19, 2018

Next step would be to move all the common entity methods and properties to a common wemo base class, and avoid the duplicated code.

@MartinHjelmare MartinHjelmare merged commit 7f0dd44 into home-assistant:dev Dec 19, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.03%
Details

@wafflebot wafflebot bot removed the in progress label Dec 19, 2018

@sqldiablo

This comment has been minimized.

Copy link
Contributor

sqldiablo commented Dec 19, 2018

Thanks, @MartinHjelmare. I have a similar set of enhancements that I want to make to the pywemo module next (to improve device rediscovery when IP or port changes, as it often does with these devices), and then I agree that we should look into removing some of the code duplication for the wemo component/platforms in HA.

@sqldiablo sqldiablo deleted the sqldiablo:wemo_rediscovery_fixes branch Dec 21, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Various enhancements for WeMo component/platforms (home-assistant#19419)
* WeMo - Various fixes and improvements

Various fixes & improvements to the WeMo components, including:
-- Fixes to rediscovery
-- New reset filter service for the WeMo Humidifier
-- Switched the remainder of the WeMo components to async IO
-- Removed any remaining IO in entity properties and moved them to the polling/subscription update process

* WeMo - Fix pywemo version and remove test code from WeMo fan component

* WeMo Humidifier - Add services.yaml entry for reset filter life service

* WeMo - Update binary_sensor component to use asyncio

* WeMo - Add available property to binary_sensor component

* WeMo - Fixed line length issue

* WeMo - Fix issue with discovering the same device multiple times

* WeMo - Fix for the fix for discovering devices multiple times

* WeMo - Fix long lines

* WeMo - Fixes from code review

* WeMo - Breaking Change - entity_ids is now required on wemo_set_humidity

* WeMo - Code review fixes

* WeMo - Code review fixes

* WeMo - Code review fixes
@sqldiablo

This comment has been minimized.

Copy link
Contributor

sqldiablo commented Jan 1, 2019

Also impacts #19153

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment