New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of MQTT light discovery #19436

Merged
merged 1 commit into from Dec 24, 2018

Conversation

Projects
None yet
3 participants
@emontnemery
Copy link
Contributor

emontnemery commented Dec 18, 2018

Description:

Improve handling of MQTT light discovery message.

When refactoring the mqtt_json and mqtt_template lights, backwards compatibility was added for MQTT discovery messages such that discovery messages setting "platform":"mqtt_json", "platform":"mqtt" or "platform":"mqtt_template" would still work by translating to the new schema configuration variable.

This PR makes the backwards compatibility more intuitive and less error prone by:

  • Not setting the schema configuration variable unless platform is light
  • Not overwriting the schema configuration variable if it is set
  • Not setting the schema configuration varible if platform is set to mqtt

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@emontnemery emontnemery force-pushed the emontnemery:fix_mqtt_light_schema branch from 6b069a6 to 200f93c Dec 19, 2018

@emontnemery emontnemery requested a review from OttoWinter Dec 21, 2018

@fabaff

fabaff approved these changes Dec 24, 2018

Copy link
Member

fabaff left a comment

Looks good to me 🐦

@fabaff fabaff merged commit a8797a0 into home-assistant:dev Dec 24, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on fix_mqtt_light_schema at 93.045%
Details

@wafflebot wafflebot bot removed the in progress label Dec 24, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 25, 2018

Merge branch 'dev' into current
* dev: (27 commits)
  Add device_id configuration option to Bluetooth tracker (home-assistant#18539)
  Add homematicip cloud full flush measuring switch (home-assistant#19247)
  Added support for triggered state on NX584 alarm. (home-assistant#19524)
  Add HomematicIP SMI55 device (home-assistant#19400)
  Clean up homematicip cloud (home-assistant#19481)
  Improve Lutron RadioRA2 support, adding switches and scenes (home-assistant#18330)
  Remove global from ZHA application controller (home-assistant#19557)
  Update homekit controller to homekit==0.12.0 (home-assistant#19549)
  Improve handling of MQTT light discovery (home-assistant#19436)
  Fix support for base topic for empty values in MQTT discovery msg (home-assistant#19501)
  Configure ZHA entity on new ZHA device join (home-assistant#19470)
  Add hub- and device-info for tellduslive (home-assistant#19180)
  Fix issues in ZHA light (home-assistant#19368)
  Updated to support per device find iphone sound. (home-assistant#19535)
  Change ISY binary_sensor subnode to hex (home-assistant#19471)
  increase robustness, when something upstream fails (home-assistant#19493)
  Support ZHA light turn_off transition (home-assistant#19531)
  Pywemo version bump (home-assistant#19538)
  Make ZHA entities non-polled by default (home-assistant#19536)
  Add ZHA occupancy sensor (home-assistant#19365)
  ...

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment