New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename air pollutants to air quality #19448

Merged
merged 10 commits into from Jan 5, 2019

Conversation

Projects
None yet
5 participants
@eliseomartelli
Copy link
Contributor

eliseomartelli commented Dec 19, 2018

Description:

Rename air pollutants to air quality

Related issue (if applicable): fixes home-assistant/architecture#122

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7901

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Have we released any of the air pollutants platforms yet? If not, this is not a breaking change.

Show resolved Hide resolved tests/components/air_quality/__init__.py
@eliseomartelli

This comment has been minimized.

Copy link
Contributor

eliseomartelli commented Dec 19, 2018

eliseomartelli added some commits Dec 19, 2018

@eliseomartelli eliseomartelli force-pushed the eliseomartelli:rename_air_quality branch from c072a1c to 9cd278e Dec 19, 2018

@eliseomartelli

This comment has been minimized.

Copy link
Contributor

eliseomartelli commented Dec 19, 2018

The last force push should fix your concerns! @MartinHjelmare

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Dec 19, 2018

This commit renames two files.
0984f63

This commit seems to remove one file and add another:
8d19d7d

Github is not always smart about this, but try to rename one file per commit. Then make additional changes after those commits.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Dec 19, 2018

Let's make sure we have a decision in the architecture issue before we merge this.

@eliseomartelli

This comment has been minimized.

Copy link
Contributor

eliseomartelli commented Dec 19, 2018

ok! @MartinHjelmare I'm setting it as a WIP

@eliseomartelli eliseomartelli changed the title Rename air pollutants to air quality WIP: Rename air pollutants to air quality Dec 19, 2018

eliseomartelli added some commits Dec 19, 2018

@eliseomartelli eliseomartelli force-pushed the eliseomartelli:rename_air_quality branch from e542897 to b2034a7 Dec 19, 2018

@eliseomartelli

This comment has been minimized.

Copy link
Contributor

eliseomartelli commented Dec 19, 2018

Let's see if it works now :) @MartinHjelmare

@eliseomartelli eliseomartelli changed the title WIP: Rename air pollutants to air quality Rename air pollutants to air quality Dec 19, 2018

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

The test module move worked now, but not the package, but that's ok I think.

For more details about this platform, please refer to the documentation at
https://home-assistant.io/components/air_pollutants_opensensemap/
https://home-assistant.io/components/air_quality_opensensemap/

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Dec 19, 2018

Member

The url is wrong. Look at eg a sensor platform to see the correct path format.

@@ -1,4 +1,4 @@
"""The tests for the Air Pollutants component."""
"""The tests for the Air Quality component."""
from homeassistant.components.air_pollutants import (

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Dec 19, 2018

Member

This module also needs updating.

eliseomartelli added some commits Dec 19, 2018

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Looks good!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Jan 2, 2019

Should we merge this first or the other platforms that are going under air pollutants? If we merge the others first we would need to convert them too here.

@fabaff?

@MartinHjelmare MartinHjelmare referenced this pull request Jan 2, 2019

Open

Add nilu air_quality platform #19674

8 of 8 tasks complete
@balloob

This comment has been minimized.

Copy link
Member

balloob commented Jan 5, 2019

We should put this in beta I think ?

@balloob balloob merged commit 3a5ba77 into home-assistant:dev Jan 5, 2019

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on rename_air_quality at 93.03%
Details

@wafflebot wafflebot bot removed the in progress label Jan 5, 2019

@balloob balloob added this to the 0.85.0 milestone Jan 5, 2019

@eliseomartelli eliseomartelli deleted the eliseomartelli:rename_air_quality branch Jan 5, 2019

@eliseomartelli

This comment has been minimized.

Copy link
Contributor

eliseomartelli commented Jan 6, 2019

@balloob yep, should be in beta :)

@hfurubotten hfurubotten referenced this pull request Jan 8, 2019

Open

Docs for nilu air_quality platform #7993

2 of 2 tasks complete

balloob added a commit that referenced this pull request Jan 9, 2019

Rename air pollutants to air quality (#19448)
* mv component folder

* moved in airquality

* changed names in files

* renamed test init

* renamed test air quality

* renamed in tests

* renamed coverage

* fixed naming

* corrected attr names

* changed attr names

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

rymsha added a commit to rymsha/home-assistant that referenced this pull request Jan 12, 2019

Rename air pollutants to air quality (home-assistant#19448)
* mv component folder

* moved in airquality

* changed names in files

* renamed test init

* renamed test air quality

* renamed in tests

* renamed coverage

* fixed naming

* corrected attr names

* changed attr names

rymsha added a commit to rymsha/home-assistant that referenced this pull request Jan 12, 2019

Rename air pollutants to air quality (home-assistant#19448)
* mv component folder

* moved in airquality

* changed names in files

* renamed test init

* renamed test air quality

* renamed in tests

* renamed coverage

* fixed naming

* corrected attr names

* changed attr names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment