New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding IPv6 to fail2ban sensor #19457

Merged
merged 5 commits into from Jan 11, 2019

Conversation

Projects
None yet
4 participants
@grea09
Copy link
Contributor

grea09 commented Dec 19, 2018

Description:

Spliting contributions from #17612. Adding regex changes and tests for IPv6 in the fail2ban sensor

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

grea09 added some commits Dec 19, 2018

Show resolved Hide resolved tests/components/sensor/test_fail2ban.py Outdated
Show resolved Hide resolved tests/components/sensor/test_fail2ban.py Outdated
Show resolved Hide resolved tests/components/sensor/test_fail2ban.py Outdated

@balloob balloob merged commit 14dd879 into home-assistant:dev Jan 11, 2019

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.004%) to 93.037%
Details

@wafflebot wafflebot bot removed the in progress label Jan 11, 2019

@balloob

This comment has been minimized.

Copy link
Member

balloob commented Jan 11, 2019

Thanks!

@balloob balloob referenced this pull request Jan 23, 2019

Merged

0.86.0 #20354

alandtse added a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019

Adding IPv6 to fail2ban sensor (home-assistant#19457)
* Fixing fail2ban regex for ipv6

* Adding IPv6 tests for fail2ban

* Formating code for hound

* Formating again

* Formating again 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment