New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure ZHA entity on new ZHA device join #19470

Merged
merged 2 commits into from Dec 23, 2018

Conversation

@Adminiuga
Copy link
Contributor

Adminiuga commented Dec 19, 2018

Description:

address #19177 comments
make new_join part of ZhaEntity and automatically call async_configure() if this entity of a freshly joined ZHA device

There's some duplicated code in zha platform for different components, this PR removes unnecessary code duplication

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
@Adminiuga

This comment has been minimized.

Copy link
Contributor

Adminiuga commented Dec 19, 2018

It is going to conflict with #19365. Please merge #19365 first and I'll rebase this one.

@dmulcahey
Copy link
Contributor

dmulcahey left a comment

LGTM, Note the dependency note before merging.

@MartinHjelmare MartinHjelmare changed the title automatically call ZhaEntity.async_configure() if it is a new join of a ZHA device WIP: Configure ZHA entity on new ZHA device join Dec 22, 2018

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Dec 22, 2018

Changed to WIP to reflect PR dependency. Remove WIP and ping me when the other PR is merged.

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Code looks good. I'll take another look after rebase before merge.

Adminiuga added some commits Dec 19, 2018

Make 'new_join' part of ZhaEntity.
Call async_configure() automatically when new device ZHA device joins.

@Adminiuga Adminiuga force-pushed the Adminiuga:zha-zcl-reporting branch from c2a1dc6 to 2186c4e Dec 22, 2018

@Adminiuga Adminiuga changed the title WIP: Configure ZHA entity on new ZHA device join Configure ZHA entity on new ZHA device join Dec 22, 2018

@Adminiuga

This comment has been minimized.

Copy link
Contributor

Adminiuga commented Dec 23, 2018

@MartinHjelmare rebased and ready for second review

@MartinHjelmare MartinHjelmare merged commit 4a1da0b into home-assistant:dev Dec 23, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.039%
Details

@wafflebot wafflebot bot removed the in progress label Dec 23, 2018

@Adminiuga Adminiuga deleted the Adminiuga:zha-zcl-reporting branch Dec 24, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Configure ZHA entity on new ZHA device join (home-assistant#19470)
* Address PR#19177 comments.

* Make 'new_join' part of ZhaEntity.

Call async_configure() automatically when new device ZHA device joins.

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 25, 2018

Merge branch 'dev' into current
* dev: (27 commits)
  Add device_id configuration option to Bluetooth tracker (home-assistant#18539)
  Add homematicip cloud full flush measuring switch (home-assistant#19247)
  Added support for triggered state on NX584 alarm. (home-assistant#19524)
  Add HomematicIP SMI55 device (home-assistant#19400)
  Clean up homematicip cloud (home-assistant#19481)
  Improve Lutron RadioRA2 support, adding switches and scenes (home-assistant#18330)
  Remove global from ZHA application controller (home-assistant#19557)
  Update homekit controller to homekit==0.12.0 (home-assistant#19549)
  Improve handling of MQTT light discovery (home-assistant#19436)
  Fix support for base topic for empty values in MQTT discovery msg (home-assistant#19501)
  Configure ZHA entity on new ZHA device join (home-assistant#19470)
  Add hub- and device-info for tellduslive (home-assistant#19180)
  Fix issues in ZHA light (home-assistant#19368)
  Updated to support per device find iphone sound. (home-assistant#19535)
  Change ISY binary_sensor subnode to hex (home-assistant#19471)
  increase robustness, when something upstream fails (home-assistant#19493)
  Support ZHA light turn_off transition (home-assistant#19531)
  Pywemo version bump (home-assistant#19538)
  Make ZHA entities non-polled by default (home-assistant#19536)
  Add ZHA occupancy sensor (home-assistant#19365)
  ...

@Adminiuga Adminiuga referenced this pull request Dec 28, 2018

Merged

Use async_configure for ZHA IAS binary sensor #19629

3 of 3 tasks complete

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment