New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3/3] mqtt-vacuum device-registry #19479

Merged
merged 13 commits into from Jan 6, 2019

Conversation

Projects
None yet
4 participants
@quazzie
Copy link
Contributor

quazzie commented Dec 20, 2018

Description:

Part 3 of 3

Add device-registry to mqtt-vacuum

Same as with part 2, need help with test.
Can't for the life of me get a grip on how the test works with tox.
Fails and i do not understand why and the logs that tox spits out do not help at all.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7910

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Show resolved Hide resolved tests/components/vacuum/common.py Outdated
Show resolved Hide resolved tests/components/vacuum/common.py Outdated
Show resolved Hide resolved tests/components/vacuum/common.py Outdated
Show resolved Hide resolved tests/components/vacuum/common.py Outdated
Show resolved Hide resolved tests/components/vacuum/common.py Outdated
Show resolved Hide resolved tests/components/vacuum/common.py Outdated
Show resolved Hide resolved homeassistant/components/vacuum/mqtt.py Outdated

@quazzie quazzie changed the title [3/3} mqtt-vacuum device-registry [3/3] mqtt-vacuum device-registry Dec 20, 2018

@quazzie quazzie force-pushed the quazzie:vacuum-devicereg branch from 34702e4 to a3caba7 Dec 20, 2018

@quazzie quazzie force-pushed the quazzie:vacuum-devicereg branch from 7e1d575 to dfd6e95 Dec 25, 2018

@quazzie quazzie force-pushed the quazzie:vacuum-devicereg branch from dfd6e95 to 23765b8 Jan 2, 2019

@emontnemery

This comment has been minimized.

Copy link
Contributor

emontnemery commented Jan 6, 2019

@quazzie #19462 is merged now, please rebase this one off dev

@quazzie quazzie force-pushed the quazzie:vacuum-devicereg branch from 23765b8 to 04c6485 Jan 6, 2019

Show resolved Hide resolved tests/components/vacuum/test_mqtt.py Outdated
Show resolved Hide resolved tests/components/vacuum/test_mqtt.py Outdated
Show resolved Hide resolved tests/components/vacuum/test_mqtt.py Outdated
Show resolved Hide resolved tests/components/vacuum/test_mqtt.py Outdated
Show resolved Hide resolved tests/components/vacuum/test_mqtt.py Outdated
Show resolved Hide resolved tests/components/vacuum/test_mqtt.py Outdated
Show resolved Hide resolved tests/components/vacuum/test_mqtt.py Outdated
Show resolved Hide resolved tests/components/vacuum/test_mqtt.py Outdated
Show resolved Hide resolved tests/components/vacuum/test_mqtt.py Outdated
Show resolved Hide resolved tests/components/vacuum/test_mqtt.py Outdated

@quazzie quazzie force-pushed the quazzie:vacuum-devicereg branch from 04c6485 to d91f241 Jan 6, 2019

quazzie added some commits Dec 18, 2018

@quazzie quazzie force-pushed the quazzie:vacuum-devicereg branch from d91f241 to 15db78d Jan 6, 2019

@emontnemery emontnemery merged commit 5b35317 into home-assistant:dev Jan 6, 2019

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.008%) to 93.073%
Details

@wafflebot wafflebot bot removed the in progress label Jan 6, 2019

@quazzie quazzie deleted the quazzie:vacuum-devicereg branch Jan 6, 2019

@balloob balloob referenced this pull request Jan 23, 2019

Merged

0.86.0 #20354

alandtse added a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment