[3/3] mqtt-vacuum device-registry #19479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
houndci-bot
reviewed
Dec 20, 2018
quazzie
changed the title
3 tasks
quazzie
force-pushed
the
vacuum-devicereg
branch
from
34702e4
to
a3caba7
Compare
houndci-bot
reviewed
Dec 20, 2018
quazzie
force-pushed
the
vacuum-devicereg
branch
from
7e1d575
to
dfd6e95
Compare
quazzie
force-pushed
the
vacuum-devicereg
branch
from
dfd6e95
to
23765b8
Compare
quazzie
force-pushed
the
vacuum-devicereg
branch
from
23765b8
to
04c6485
Compare
houndci-bot
reviewed
Jan 6, 2019
quazzie
force-pushed
the
vacuum-devicereg
branch
from
04c6485
to
d91f241
Compare
quazzie
force-pushed
the
vacuum-devicereg
branch
from
d91f241
to
15db78d
Compare
emontnemery
approved these changes
Jan 6, 2019
Merged
alandtse
pushed a commit
to alandtse/home-assistant
that referenced
this pull request
Feb 12, 2019
* add device registry to mqtt-vacuum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Part 3 of 3
Add device-registry to mqtt-vacuum
Same as with part 2, need help with test.
Can't for the life of me get a grip on how the test works with tox.
Fails and i do not understand why and the logs that tox spits out do not help at all.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7910
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: