New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up homematicip cloud #19481

Merged
merged 3 commits into from Dec 25, 2018

Conversation

Projects
None yet
4 participants
@sander76
Copy link
Contributor

sander76 commented Dec 20, 2018

Code has some inconsistencies. Improving log messages, retry-counting fix, removed unused method and other small fixes

@sander76

This comment has been minimized.

Copy link
Contributor

sander76 commented Dec 24, 2018

@mxworm Just to let you know.

@mxworm

This comment has been minimized.

Copy link
Contributor

mxworm commented Dec 24, 2018

@sander76 Thanks for the fixes!
How to proceed with the missing components?

@sander76

This comment has been minimized.

Copy link
Contributor

sander76 commented Dec 24, 2018

@mxworm I've got some devices I have myself. Those I can implement and test. When I find the time. The others I'm not sure how to proceed. I guess we should just implement them and when hass users start to report bugs we should try and fix them based on their feedback. Unless someone is willing to sponsor us with all hmip devices available in the market ;-)

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Are we ready to merge?

@@ -138,6 +138,8 @@ def async_update(self, *args, **kwargs):
self._accesspoint_connected = False
self.set_all_to_unavailable()
elif not self._accesspoint_connected:
# Now the HOME_CHANGED event has fired indicating the access
# point has reconnected to the could again.

This comment has been minimized.

@MartinHjelmare
@sander76

This comment has been minimized.

Copy link
Contributor

sander76 commented Dec 25, 2018

@MartinHjelmare ready to merge after I fix the typo. After that a rebase ?

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Great!

@MartinHjelmare MartinHjelmare changed the title Better logging, remove unused method, re-try handling fix. Other mino… Clean up homematicip cloud Dec 25, 2018

@MartinHjelmare MartinHjelmare merged commit 18b7f74 into home-assistant:dev Dec 25, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.006%) to 93.057%
Details

@wafflebot wafflebot bot removed the in progress label Dec 25, 2018

@sander76

This comment has been minimized.

Copy link
Contributor

sander76 commented Dec 25, 2018

@MartinHjelmare you're the best 👍

@mxworm

This comment has been minimized.

Copy link
Contributor

mxworm commented Dec 25, 2018

Thanks!

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Clean up homematicip cloud (home-assistant#19481)
* Better logging, remove unused method, re-try handling fix. Other minor fixes.

* fix test

* typo fix

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 25, 2018

Merge branch 'dev' into current
* dev: (27 commits)
  Add device_id configuration option to Bluetooth tracker (home-assistant#18539)
  Add homematicip cloud full flush measuring switch (home-assistant#19247)
  Added support for triggered state on NX584 alarm. (home-assistant#19524)
  Add HomematicIP SMI55 device (home-assistant#19400)
  Clean up homematicip cloud (home-assistant#19481)
  Improve Lutron RadioRA2 support, adding switches and scenes (home-assistant#18330)
  Remove global from ZHA application controller (home-assistant#19557)
  Update homekit controller to homekit==0.12.0 (home-assistant#19549)
  Improve handling of MQTT light discovery (home-assistant#19436)
  Fix support for base topic for empty values in MQTT discovery msg (home-assistant#19501)
  Configure ZHA entity on new ZHA device join (home-assistant#19470)
  Add hub- and device-info for tellduslive (home-assistant#19180)
  Fix issues in ZHA light (home-assistant#19368)
  Updated to support per device find iphone sound. (home-assistant#19535)
  Change ISY binary_sensor subnode to hex (home-assistant#19471)
  increase robustness, when something upstream fails (home-assistant#19493)
  Support ZHA light turn_off transition (home-assistant#19531)
  Pywemo version bump (home-assistant#19538)
  Make ZHA entities non-polled by default (home-assistant#19536)
  Add ZHA occupancy sensor (home-assistant#19365)
  ...

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment