New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement path in the config to fix issues for some users #19491

Merged
merged 2 commits into from Dec 22, 2018

Conversation

Projects
None yet
3 participants
@wcomartin
Copy link
Contributor

wcomartin commented Dec 20, 2018

Description:

Fixes an issue brought to me by a tautulli user, the sensor was unable to reach his tautulli instance because he uses a tautulli setting "Base URL" which changes the routes in tautulli to use that base

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7915

Example entry for configuration.yaml (if applicable):

  - platform: tautulli
    host: !secret tautulli_host
    port: 443
    path: "/tautulli"
    api_key: !secret tautulli

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

wcomartin added some commits Dec 20, 2018

Update Tautulli sensor dependency pytautulli
Implement path in the config to fix issues for some users

@wcomartin wcomartin requested a review from ludeeus as a code owner Dec 20, 2018

@homeassistant

This comment has been minimized.

Copy link

homeassistant commented Dec 20, 2018

Hi @wcomartin,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@cgarwood cgarwood merged commit 2765440 into home-assistant:dev Dec 22, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot All contributors have signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.009%) to 93.043%
Details

@wafflebot wafflebot bot removed the in progress label Dec 22, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Implement path in the config to fix issues for some users (home-assis…
…tant#19491)

* Update Tautulli sensor dependency pytautulli

Implement path in the config to fix issues for some users

* Add requirement

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment