New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove webhook setup check if base url is local #19494

Merged
merged 1 commit into from Dec 21, 2018

Conversation

Projects
None yet
3 participants
@balloob
Copy link
Member

balloob commented Dec 20, 2018

Description:

Webhook config flow helper had a check that canceled the flow if we detected that we're not internet accessible. However, this breaks if we're integrating with a service with local webhooks (Plex), if the base url is not properly configured or if we're going to make the webhook cloud accessible.

This removes the check.

If you're running into this, a temporary workaround is to set the base url to your hostname in your configuration.yaml:

http:
  base_url: "hassio:8123"

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from home-assistant/core as a code owner Dec 20, 2018

@wafflebot wafflebot bot added the in progress label Dec 20, 2018

@pvizeli pvizeli merged commit 1281da0 into dev Dec 21, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.001%) to 93.054%
Details

@wafflebot wafflebot bot removed the in progress label Dec 21, 2018

@delete-merged-branch delete-merged-branch bot deleted the remove-webhook-external-check branch Dec 21, 2018

@balloob balloob added this to the 0.84.6 milestone Dec 21, 2018

balloob added a commit that referenced this pull request Dec 21, 2018

@balloob balloob referenced this pull request Dec 21, 2018

Merged

0.84.6 #19505

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 22, 2018

Merge branch 'dev' into current
* dev: (22 commits)
  Update yale smart alarm client to v0.1.6 (home-assistant#19495)
  Add deprecation warning (home-assistant#19515)
  Restore state for zha binary_sensors on restart. (home-assistant#19314)
  Add ZHA battery sensor (home-assistant#19363)
  Clean up RFLink tests and add two tests (home-assistant#19511)
  Allow scrape sensor to retry setting up platform if initial setup fails (home-assistant#19498)
  Add Lutron Homeworks component (home-assistant#18311)
  Disable creating port mappings from UI, add discovery from component (home-assistant#18565)
  Bumped version to 0.84.6
  Remove check if base url is local (home-assistant#19494)
  Remove check if base url is local (home-assistant#19494)
  Bumped version to 0.84.5
  Bump pyharmony (home-assistant#19460)
  Bumped version to 0.84.4
  Use web sockets for Harmony HUB (home-assistant#19440)
  Fix IHC config schema (home-assistant#19415)
  Updated frontend to 20181211.2
  Bumped version to 0.84.3
  Fix not being able to update entities (home-assistant#19344)
  Fix restore state for manual alarm control panel (home-assistant#19284)
  ...

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment