New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrape sensor initial failed setup #19498

Merged
merged 1 commit into from Dec 22, 2018

Conversation

Projects
None yet
3 participants
@uchagani
Copy link
Contributor

uchagani commented Dec 21, 2018

Description:

Allow scrape sensor to retry setup if initial setup fails (like the rest sensor does).

Related issue (if applicable): fixes #19488

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: scrape
    resource: https://www.abcd-home-assistant.io
    select: ".current-version h1"

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@uchagani uchagani requested a review from fabaff as a code owner Dec 21, 2018

@wafflebot wafflebot bot added the in progress label Dec 21, 2018

@uchagani uchagani changed the title allow scrape sensor to retry setting up platform if initial setup fails Bug Fix: Make scrape sensor retry if initial setup fails Dec 21, 2018

@MartinHjelmare MartinHjelmare changed the title Bug Fix: Make scrape sensor retry if initial setup fails Fix scrape sensor initial failed setup Dec 22, 2018

@MartinHjelmare MartinHjelmare merged commit 3a3d488 into home-assistant:dev Dec 22, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 93.045%
Details

@wafflebot wafflebot bot removed the in progress label Dec 22, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 22, 2018

Merge branch 'dev' into current
* dev: (22 commits)
  Update yale smart alarm client to v0.1.6 (home-assistant#19495)
  Add deprecation warning (home-assistant#19515)
  Restore state for zha binary_sensors on restart. (home-assistant#19314)
  Add ZHA battery sensor (home-assistant#19363)
  Clean up RFLink tests and add two tests (home-assistant#19511)
  Allow scrape sensor to retry setting up platform if initial setup fails (home-assistant#19498)
  Add Lutron Homeworks component (home-assistant#18311)
  Disable creating port mappings from UI, add discovery from component (home-assistant#18565)
  Bumped version to 0.84.6
  Remove check if base url is local (home-assistant#19494)
  Remove check if base url is local (home-assistant#19494)
  Bumped version to 0.84.5
  Bump pyharmony (home-assistant#19460)
  Bumped version to 0.84.4
  Use web sockets for Harmony HUB (home-assistant#19440)
  Fix IHC config schema (home-assistant#19415)
  Updated frontend to 20181211.2
  Bumped version to 0.84.3
  Fix not being able to update entities (home-assistant#19344)
  Fix restore state for manual alarm control panel (home-assistant#19284)
  ...

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment