New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Envisalink pgm #19499

Merged
merged 5 commits into from Jan 2, 2019

Conversation

Projects
None yet
5 participants
@Cinntax
Copy link
Contributor

Cinntax commented Dec 21, 2018

Description:

This release will allow users of the DSC panels to leverage custom functions on their panels to control things like garage door openers. This has been requested several times. In addition, the "code" parameter is now optional for people that wish to not include the code, and enter it in at runtime. Also resolved issue 18422.

Related issue (if applicable): fixes #18422

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7919

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@wafflebot wafflebot bot added the in progress label Dec 21, 2018

@Cinntax Cinntax referenced this pull request Dec 21, 2018

Merged

Update envisalink component #7919

2 of 2 tasks complete
@Cinntax

This comment has been minimized.

Copy link
Contributor

Cinntax commented Dec 24, 2018

Would it be possible to get some guidance on how I need to handle this build fail? The failure that is being called out has nothing to do with the code change I'm proposing...

@Cinntax

This comment has been minimized.

Copy link
Contributor

Cinntax commented Dec 29, 2018

Wondering if you had any thoughts on this, @MartinHjelmare , I'm not sure what I can do to fix this since it appears the travis build failure is unrelated to my change.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Dec 30, 2018

Don't worry about that test. It's flaky.

@Cinntax

This comment has been minimized.

Copy link
Contributor

Cinntax commented Dec 30, 2018

Okay great thank you!!

Show resolved Hide resolved homeassistant/components/envisalink.py Outdated
Show resolved Hide resolved homeassistant/components/envisalink.py Outdated
Show resolved Hide resolved homeassistant/components/envisalink.py Outdated
Show resolved Hide resolved homeassistant/components/envisalink.py Outdated
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Great!

@MartinHjelmare MartinHjelmare merged commit a10ca95 into home-assistant:dev Jan 2, 2019

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 93.107%
Details

@wafflebot wafflebot bot removed the in progress label Jan 2, 2019

@ngardiner

This comment has been minimized.

Copy link

ngardiner commented Jan 2, 2019

Hi @Cinntax, just wanted to thank you for the fix for #18422. This will help us greatly with the component stability. I can't test it in dev branch unfortunately (given I don't have a test panel to work with) but can certainly try it out in the next release as the issues are reproducable on my side.

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

I forgot to look for a service description.

We should define a services.yaml file with service description for the custom service. This requires us to move the component module to a package. Ie move and rename components/envisalink.py to components/envisalink/__init__.py. Then make a file components/envisalink/services.yaml. See other components for examples. Please make a new PR with those changes.

Sorry that I missed this.

@Cinntax

This comment has been minimized.

Copy link
Contributor

Cinntax commented Jan 2, 2019

Okay sure no problem- it's my first time doing a custom service so I missed the requirement too. I'll get that done today.

@Cinntax

This comment has been minimized.

Copy link
Contributor

Cinntax commented Jan 2, 2019

In the meantime I'll at least have people test the fix for 18422.

sqldiablo added a commit to sqldiablo/home-assistant that referenced this pull request Jan 2, 2019

Envisalink pgm (home-assistant#19499)
* Added a new service for calling custom PGM functions.

* Fixed lint issues

* Fixed lint issues reported by travis-CI

* Fixed style issue.

* Complete rename of attribute.

sqldiablo added a commit to sqldiablo/home-assistant that referenced this pull request Jan 3, 2019

Envisalink pgm (home-assistant#19499)
* Added a new service for calling custom PGM functions.

* Fixed lint issues

* Fixed lint issues reported by travis-CI

* Fixed style issue.

* Complete rename of attribute.

@Cinntax Cinntax deleted the Cinntax:envisalink_PGM branch Jan 3, 2019

@Cinntax Cinntax referenced this pull request Jan 3, 2019

Merged

Move envisalink component to package and add services.yaml #19731

5 of 9 tasks complete

mxworm added a commit to mxworm/home-assistant that referenced this pull request Jan 3, 2019

Merge branch 'dev' into current
* dev:
  Adds ability to calibrate temperature for BME680 (home-assistant#19684)
  Bumping aioasuswrt version to 1.1.17 (home-assistant#19714)
  Bump pyotgw to 0.4b1 (home-assistant#19715)
  Envisalink pgm (home-assistant#19499)
  Update pyhomematic 0.1.54 + small fixes (home-assistant#19667)
  Add ness alarm control panel using nessclient (home-assistant#18463)
  Add support for color_temp_command_template in MQTT light component (home-assistant#19675)
  Improve rflink coverage (home-assistant#19596)
  Luftdaten traceback (home-assistant#19666)
  Fix london_underground issue (home-assistant#19642)
  Add IDTECK proximity card component (home-assistant#18309)
  Fix homekit_controller pairing regression (home-assistant#19654)
  Fix error in got_connected for remote.harmony (home-assistant#19662)
  Fix exception checking for next dublin bus (home-assistant#19663)
  Added regexp validation allowing Twilio notifications to use Sender ID instead of phone number (home-assistant#19644)
  pytraccar version bump (home-assistant#19659)
  Suppress traceback if network is not available

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

kellerza added a commit to kellerza/home-assistant that referenced this pull request Jan 18, 2019

Envisalink pgm (home-assistant#19499)
* Added a new service for calling custom PGM functions.

* Fixed lint issues

* Fixed lint issues reported by travis-CI

* Fixed style issue.

* Complete rename of attribute.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment