New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up RFLink tests and add two tests #19511

Merged
merged 2 commits into from Dec 22, 2018

Conversation

Projects
None yet
3 participants
@javicalle
Copy link
Contributor

javicalle commented Dec 21, 2018

Description:

After releasing the PR #18816, I made some additional changes in the tests to make them homogeneous with the other changes applied.
This PR contains small refactorings and some additional tests.

Related issue (if applicable): N/A

Pull request in home-assistant.io with documentation (if applicable): N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example). N/A
  • New dependencies are only imported inside functions that use them (example). N/A
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py. N/A
  • New files were added to .coveragerc. N/A

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@javicalle javicalle changed the title [WIP] some minor RFLink tests refactor Some minor RFLink tests refactor Dec 21, 2018

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Nice!

Show resolved Hide resolved tests/components/test_rflink.py

@MartinHjelmare MartinHjelmare changed the title Some minor RFLink tests refactor Clean up RFLink tests and add two tests Dec 22, 2018

@MartinHjelmare MartinHjelmare merged commit fb226e3 into home-assistant:dev Dec 22, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.03%
Details

@wafflebot wafflebot bot removed the in progress label Dec 22, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 22, 2018

Merge branch 'dev' into current
* dev: (22 commits)
  Update yale smart alarm client to v0.1.6 (home-assistant#19495)
  Add deprecation warning (home-assistant#19515)
  Restore state for zha binary_sensors on restart. (home-assistant#19314)
  Add ZHA battery sensor (home-assistant#19363)
  Clean up RFLink tests and add two tests (home-assistant#19511)
  Allow scrape sensor to retry setting up platform if initial setup fails (home-assistant#19498)
  Add Lutron Homeworks component (home-assistant#18311)
  Disable creating port mappings from UI, add discovery from component (home-assistant#18565)
  Bumped version to 0.84.6
  Remove check if base url is local (home-assistant#19494)
  Remove check if base url is local (home-assistant#19494)
  Bumped version to 0.84.5
  Bump pyharmony (home-assistant#19460)
  Bumped version to 0.84.4
  Use web sockets for Harmony HUB (home-assistant#19440)
  Fix IHC config schema (home-assistant#19415)
  Updated frontend to 20181211.2
  Bumped version to 0.84.3
  Fix not being able to update entities (home-assistant#19344)
  Fix restore state for manual alarm control panel (home-assistant#19284)
  ...

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Clean up RFLink tests and add two tests (home-assistant#19511)
* some minor tests refactor

* unused import

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment