New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added events STARTED, RESTARTED and PAUSED #19516

Merged
merged 1 commit into from Dec 29, 2018

Conversation

Projects
None yet
4 participants
@mjrider
Copy link
Contributor

mjrider commented Dec 22, 2018

Description:

This add's 3 new events in a timer components.

  • started when a timer is started
  • paused when a timer is paused
  • restarted when a timer is restarted after a pause

Tests:

the 'wait for the timer to finish' part of the test is now it's own test.
The rest is a sequence of fire/assert. Which i rewrote to a loop to
reduce the amount of duplicate code

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7925

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

if the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Added events STARTED, RESTARTED AND PAUSED
Rewrote the tests a bit
the 'wait for the timer to finish' part of the test is now it's own test.
The rest is a sequence of fire/assert. Which i rewrote to a loop to
reduce the amount of duplicate code

@wafflebot wafflebot bot added the in progress label Dec 22, 2018

mjrider added a commit to mjrider/home-assistant.io that referenced this pull request Dec 22, 2018

mjrider added a commit to mjrider/home-assistant.io that referenced this pull request Dec 22, 2018

@mjrider mjrider referenced this pull request Dec 22, 2018

Merged

Document the changes in timer #7925

2 of 2 tasks complete

@mjrider mjrider changed the title WIP: Added events STARTED, RESTARTED AND PAUSED Added events STARTED, RESTARTED AND PAUSED Dec 22, 2018

mjrider added a commit to mjrider/home-assistant.io that referenced this pull request Dec 23, 2018

@fabaff fabaff changed the title Added events STARTED, RESTARTED AND PAUSED Added events STARTED, RESTARTED and PAUSED Dec 25, 2018

@fabaff

fabaff approved these changes Dec 29, 2018

Copy link
Member

fabaff left a comment

Looks good to me 🐦

@fabaff fabaff merged commit 9928b97 into home-assistant:dev Dec 29, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.005%) to 93.036%
Details

@wafflebot wafflebot bot removed the in progress label Dec 29, 2018

fabaff added a commit to home-assistant/home-assistant.io that referenced this pull request Dec 29, 2018

Document the changes in timer (#7925)
* Document the changes in timerrelated to home-assistant/home-assistant#19516

* 📝 Tweaks
SERVICE_PAUSE,
{CONF_ENTITY_ID: 'timer.test1'})
yield from hass.async_block_till_done()
expectedEvents = 0

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Dec 30, 2018

Member

Variable names should be lowercase snakecase.

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 30, 2018

Merge branch 'dev' into current
* dev: (44 commits)
  Fix ADS light when parameter adsvar_brightness is not set (home-assistant#19636)
  Bump pyHik library to 0.1.9 to improve device support. (home-assistant#19656)
  Use aioharmony for remote.harmony platform (home-assistant#19595)
  Add RaspyRFM switch platform (home-assistant#19130)
  Only bind clusters in ZHA remote entity (home-assistant#19577)
  Use async_configure for ZHA IAS binary sensor (home-assistant#19629)
  Improve Wemo setup speed (home-assistant#19563)
  Support knx operation types (home-assistant#19546)
  Use xml.etree through defusedxml (home-assistant#19640)
  Fix cpu_temp issue on Vero 4K (home-assistant#19638)
  Added events STARTED, RESTARTED AND PAUSED (home-assistant#19516)
  Revert "Bump pyotgw to 0.4b0 (home-assistant#19618)" (home-assistant#19635)
  Upgrade to async_upnp_client==0.13.8 (home-assistant#19634)
  Upgraded pyarlo to 0.2.3 (home-assistant#19626)
  Fix cpu_temp issue on Odroid (home-assistant#19620)
  Bump pyotgw to 0.4b0 (home-assistant#19618)
  Add additional neato alerts and errors (home-assistant#19608)
  LCN component and light platform (home-assistant#18621)
  Systemmonitor - add device_class property (home-assistant#19614)
  Upgrade huawei-lte-api to 1.1.1 (home-assistant#19615)
  ...

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment