Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Mill connection problem #19519

Merged
merged 4 commits into from Dec 22, 2018
Merged

Fix Mill connection problem #19519

merged 4 commits into from Dec 22, 2018

Conversation

Danielhiversen
Copy link
Member

Description:

Fix Mill connection problem

https://github.com/Danielhiversen/pymill/commits/master

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@ghost ghost assigned Danielhiversen Dec 22, 2018
@ghost ghost added the in progress label Dec 22, 2018
@MartinHjelmare MartinHjelmare merged commit ef53a2d into dev Dec 22, 2018
@delete-merged-branch delete-merged-branch bot deleted the mill_connection branch December 22, 2018 18:01
@ghost ghost removed the in progress label Dec 22, 2018
dshokouhi pushed a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018
@Danielhiversen @dshokouhi
Fix Mill connection problem (home-assistant#19519)
e8986e2 
* Update mill library, improve connection

* Mill connection

* revert print

* Mill connection
@balloob balloob mentioned this pull request Jan 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

@Danielhiversen Danielhiversen

Labels
cla-signed integration: mill small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Danielhiversen @MartinHjelmare @homeassistant