New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ZHA entities non-polled by default #19536

Merged
merged 1 commit into from Dec 23, 2018

Conversation

Projects
None yet
4 participants
@Adminiuga
Copy link
Contributor

Adminiuga commented Dec 23, 2018

Description:

Most of ZHA entities are polled non-polled by default anyway, so move def should_poll(self) to ZhaEntity class definition, allowing override on per entity basis.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
@Adminiuga

This comment has been minimized.

Copy link
Contributor

Adminiuga commented Dec 23, 2018

restart Travis...

@Adminiuga Adminiuga closed this Dec 23, 2018

@Adminiuga Adminiuga reopened this Dec 23, 2018

@wafflebot wafflebot bot added in progress and removed in progress labels Dec 23, 2018

@Adminiuga Adminiuga changed the title Make ZHA entities polled by default. Make ZHA entities non-polled by default. Dec 23, 2018

@MartinHjelmare MartinHjelmare changed the title Make ZHA entities non-polled by default. Make ZHA entities non-polled by default Dec 23, 2018

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Dec 23, 2018

Please fix the use of global for the APPLICATION_CONTROLLER next.

@MartinHjelmare MartinHjelmare merged commit 01fc322 into home-assistant:dev Dec 23, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 93.029%
Details

@wafflebot wafflebot bot removed the in progress label Dec 23, 2018

@Adminiuga Adminiuga deleted the Adminiuga:zha-dev-poll branch Dec 24, 2018

@dmulcahey

This comment has been minimized.

Copy link
Contributor

dmulcahey commented Dec 24, 2018

Please fix the use of global for the APPLICATION_CONTROLLER next.

@MartinHjelmare what should we do there? I'll do what's necessary. I'm just not sure what it is that we have to change...

@Adminiuga

This comment has been minimized.

Copy link
Contributor

Adminiuga commented Dec 24, 2018

I think we need to make zha component work without having global APPLICATION_CONTROLLER anywhere in the code. Put it somewhere under hass.data['ZHA'] ?

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Dec 24, 2018

Yes!

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 25, 2018

Merge branch 'dev' into current
* dev: (27 commits)
  Add device_id configuration option to Bluetooth tracker (home-assistant#18539)
  Add homematicip cloud full flush measuring switch (home-assistant#19247)
  Added support for triggered state on NX584 alarm. (home-assistant#19524)
  Add HomematicIP SMI55 device (home-assistant#19400)
  Clean up homematicip cloud (home-assistant#19481)
  Improve Lutron RadioRA2 support, adding switches and scenes (home-assistant#18330)
  Remove global from ZHA application controller (home-assistant#19557)
  Update homekit controller to homekit==0.12.0 (home-assistant#19549)
  Improve handling of MQTT light discovery (home-assistant#19436)
  Fix support for base topic for empty values in MQTT discovery msg (home-assistant#19501)
  Configure ZHA entity on new ZHA device join (home-assistant#19470)
  Add hub- and device-info for tellduslive (home-assistant#19180)
  Fix issues in ZHA light (home-assistant#19368)
  Updated to support per device find iphone sound. (home-assistant#19535)
  Change ISY binary_sensor subnode to hex (home-assistant#19471)
  increase robustness, when something upstream fails (home-assistant#19493)
  Support ZHA light turn_off transition (home-assistant#19531)
  Pywemo version bump (home-assistant#19538)
  Make ZHA entities non-polled by default (home-assistant#19536)
  Add ZHA occupancy sensor (home-assistant#19365)
  ...

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment