New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelisting of lines on entur sensor #19539

Merged
merged 1 commit into from Dec 25, 2018

Conversation

Projects
None yet
3 participants
@hfurubotten
Copy link
Contributor

hfurubotten commented Dec 23, 2018

Description:

A requested feature from users, that has come in from multiple channels, is to filter out unwanted lines from the stop places on their sensors. This update will support a whitelisting of public transport lines that should be the only ones that show up on the sensors.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7932

Example entry for configuration.yaml (if applicable):

# Example configuration.yaml entry
sensor:
  - platform: entur_public_transport
    stop_ids:
      - 'NSR:Quay:7333'
      - 'NSR:Quay:48550'
      - 'NSR:StopPlace:596'
    line_whitelist:
      - 'RUT:Line:1'
      - 'KOL:Line:1000_236'
      - 'NSB:Line:59'

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@wafflebot wafflebot bot added the in progress label Dec 23, 2018

@hfurubotten hfurubotten referenced this pull request Dec 23, 2018

Merged

Updated entur platform with line_whitelist and faq #7932

2 of 2 tasks complete

@hfurubotten hfurubotten changed the title WIP: Whitelisting of lines on entur sensor Whitelisting of lines on entur sensor Dec 23, 2018

@fabaff

fabaff approved these changes Dec 25, 2018

Copy link
Member

fabaff left a comment

Looks good to me 🐦

@fabaff fabaff merged commit 47f8d24 into home-assistant:dev Dec 25, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 93.029%
Details

@wafflebot wafflebot bot removed the in progress label Dec 25, 2018

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment