New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update homekit controller to homekit==0.12.0 #19549

Merged
merged 1 commit into from Dec 24, 2018

Conversation

@Jc2k
Copy link
Contributor

Jc2k commented Dec 23, 2018

Description:

This bumps the underlying homekit_controller code to use homekit==0.12.0. It uses the new Controller API in that release. This starts to remove assumptions about IP based homekit accessories in anticipation of BLE support in a future release.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@homeassistant

This comment has been minimized.

Copy link

homeassistant commented Dec 23, 2018

Hi @Jc2k,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Looks good!

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Just two clean ups possible.

@Jc2k Jc2k force-pushed the Jc2k:homekit_python_0_12 branch from 8e94c35 to 3f3bf65 Dec 24, 2018

@Jc2k

This comment has been minimized.

Copy link
Contributor

Jc2k commented Dec 24, 2018

Thanks for the quick review! I've applied both suggested changes to my branch.

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Good!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Dec 24, 2018

For the future, please don't squash commits after review has started to make it easier for readers to track changes.

@MartinHjelmare MartinHjelmare changed the title Update to homekit==0.12.0 Update homekit controller to homekit==0.12.0 Dec 24, 2018

@MartinHjelmare MartinHjelmare merged commit e0f50a9 into home-assistant:dev Dec 24, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.009%) to 93.036%
Details

@wafflebot wafflebot bot removed the in progress label Dec 24, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 25, 2018

Merge branch 'dev' into current
* dev: (27 commits)
  Add device_id configuration option to Bluetooth tracker (home-assistant#18539)
  Add homematicip cloud full flush measuring switch (home-assistant#19247)
  Added support for triggered state on NX584 alarm. (home-assistant#19524)
  Add HomematicIP SMI55 device (home-assistant#19400)
  Clean up homematicip cloud (home-assistant#19481)
  Improve Lutron RadioRA2 support, adding switches and scenes (home-assistant#18330)
  Remove global from ZHA application controller (home-assistant#19557)
  Update homekit controller to homekit==0.12.0 (home-assistant#19549)
  Improve handling of MQTT light discovery (home-assistant#19436)
  Fix support for base topic for empty values in MQTT discovery msg (home-assistant#19501)
  Configure ZHA entity on new ZHA device join (home-assistant#19470)
  Add hub- and device-info for tellduslive (home-assistant#19180)
  Fix issues in ZHA light (home-assistant#19368)
  Updated to support per device find iphone sound. (home-assistant#19535)
  Change ISY binary_sensor subnode to hex (home-assistant#19471)
  increase robustness, when something upstream fails (home-assistant#19493)
  Support ZHA light turn_off transition (home-assistant#19531)
  Pywemo version bump (home-assistant#19538)
  Make ZHA entities non-polled by default (home-assistant#19536)
  Add ZHA occupancy sensor (home-assistant#19365)
  ...

@Jc2k Jc2k referenced this pull request Dec 30, 2018

Merged

Fix homekit_controller pairing regression #19654

0 of 6 tasks complete

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment