New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove global from ZHA application controller #19557

Merged
merged 3 commits into from Dec 25, 2018

Conversation

Projects
None yet
3 participants
@dmulcahey
Copy link
Contributor

dmulcahey commented Dec 24, 2018

Remove global and stash ZHA's application controller in hass.data.

@MartinHjelmare Let me know if this isn't what you were thinking.

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Don't we need to access the controller from any other modules?

Show resolved Hide resolved homeassistant/components/zha/__init__.py Outdated
@dmulcahey

This comment has been minimized.

Copy link
Contributor

dmulcahey commented Dec 24, 2018

Don't we need to access the controller from any other modules?

@MartinHjelmare Nope. Everything is handled through events on the listener.

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Nice!

@MartinHjelmare MartinHjelmare merged commit bef85ec into home-assistant:dev Dec 25, 2018

4 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Dec 25, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Remove global from ZHA application controller (home-assistant#19557)
* remove global from application controller per request

* remove unneeded line

* don't store controller application in hass.data - review comment

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 25, 2018

Merge branch 'dev' into current
* dev: (27 commits)
  Add device_id configuration option to Bluetooth tracker (home-assistant#18539)
  Add homematicip cloud full flush measuring switch (home-assistant#19247)
  Added support for triggered state on NX584 alarm. (home-assistant#19524)
  Add HomematicIP SMI55 device (home-assistant#19400)
  Clean up homematicip cloud (home-assistant#19481)
  Improve Lutron RadioRA2 support, adding switches and scenes (home-assistant#18330)
  Remove global from ZHA application controller (home-assistant#19557)
  Update homekit controller to homekit==0.12.0 (home-assistant#19549)
  Improve handling of MQTT light discovery (home-assistant#19436)
  Fix support for base topic for empty values in MQTT discovery msg (home-assistant#19501)
  Configure ZHA entity on new ZHA device join (home-assistant#19470)
  Add hub- and device-info for tellduslive (home-assistant#19180)
  Fix issues in ZHA light (home-assistant#19368)
  Updated to support per device find iphone sound. (home-assistant#19535)
  Change ISY binary_sensor subnode to hex (home-assistant#19471)
  increase robustness, when something upstream fails (home-assistant#19493)
  Support ZHA light turn_off transition (home-assistant#19531)
  Pywemo version bump (home-assistant#19538)
  Make ZHA entities non-polled by default (home-assistant#19536)
  Add ZHA occupancy sensor (home-assistant#19365)
  ...

@dmulcahey dmulcahey deleted the dmulcahey:dm/zha-application-controller-global branch Dec 26, 2018

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment