New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pylaunches dependency to 0.2.0 #19570

Merged
merged 2 commits into from Dec 25, 2018

Conversation

Projects
None yet
4 participants
@DoloresHA
Copy link
Contributor

DoloresHA commented Dec 25, 2018

Breaking change
The launch_time sensor attribute will now be a datetime which can be used in templates, as opposed to a written word string.

Description:

Update launch library to use pylaunches 0.2.0 as a dependency. launch_time sensor attribute will now be passed in ISO format, allowing for templating/easier automating with this attribute.
Bump Space Launch Sensor to pylaunches 0.2.0.

**Related issue (if applicable): None

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Update pylaunches dependency to 0.2.0
Update launch library to use pylaunches 0.2.0 as a dependency. launch_time sensor attribute will now be passed in ISO format, allowing for templating/easier automating with this attribute.
@DoloresHA

This comment has been minimized.

Copy link
Contributor

DoloresHA commented Dec 25, 2018

requirements_all.txt was updated manually in github as I do not have a dev environment... not sure if this is acceptable.

@fabaff

fabaff approved these changes Dec 25, 2018

Copy link
Member

fabaff left a comment

🐦

@fabaff fabaff merged commit 796b195 into home-assistant:dev Dec 25, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.009%) to 93.049%
Details

@wafflebot wafflebot bot removed the in progress label Dec 25, 2018

@DoloresHA DoloresHA deleted the DoloresHA:patch-3 branch Dec 26, 2018

@ludeeus

This comment has been minimized.

Copy link
Member

ludeeus commented Dec 27, 2018

@DoloresHA This changes the way the data is presented for that attribute, can you add a note that can be copied to the releasenotes in the description?

@DoloresHA

This comment has been minimized.

Copy link
Contributor

DoloresHA commented Dec 29, 2018

@ludeeus the following description was added to the PR. It's not super-thorough but seems more detailed than most others. 😛 Let me know if it should be updated further. Thank you again!

Bump Space Launch Sensor to pylaunches 0.2.0. The launch_time sensor attribute will now be a datetime which can be used in templates, as opposed to a written word string.

@ludeeus

This comment has been minimized.

Copy link
Member

ludeeus commented Dec 30, 2018

Updated the comment so it is easier to see that part, thanks @DoloresHA :)

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment