New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only bind clusters in ZHA remote entity #19577

Merged
merged 3 commits into from Dec 30, 2018

Conversation

Projects
None yet
4 participants
@dmulcahey
Copy link
Contributor

dmulcahey commented Dec 26, 2018

Previously we were configuring reporting on output clusters in the "remote" entity in ZHA. This is unnecessary because all of the functionality occurs over cluster commands which only require binding. This PR does the following:

  1. Splits bind and configure reporting functionality into separate helpers
  2. Creates an aggregate helper that calls the previously mentioned helpers in sequence
  3. Overrides async_configure in the remote entity so that it only calls bind

dmulcahey added some commits Dec 26, 2018

@dmulcahey

This comment has been minimized.

Copy link
Contributor

dmulcahey commented Dec 26, 2018

Kicking Travis

@dmulcahey dmulcahey closed this Dec 26, 2018

@wafflebot wafflebot bot removed the in progress label Dec 26, 2018

@dmulcahey dmulcahey reopened this Dec 26, 2018

@wafflebot wafflebot bot added the in progress label Dec 26, 2018

@Adminiuga
Copy link
Contributor

Adminiuga left a comment

Looks good!

@MartinHjelmare MartinHjelmare merged commit d0742cb into home-assistant:dev Dec 30, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 93.049%
Details

@wafflebot wafflebot bot removed the in progress label Dec 30, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 30, 2018

Merge branch 'dev' into current
* dev: (44 commits)
  Fix ADS light when parameter adsvar_brightness is not set (home-assistant#19636)
  Bump pyHik library to 0.1.9 to improve device support. (home-assistant#19656)
  Use aioharmony for remote.harmony platform (home-assistant#19595)
  Add RaspyRFM switch platform (home-assistant#19130)
  Only bind clusters in ZHA remote entity (home-assistant#19577)
  Use async_configure for ZHA IAS binary sensor (home-assistant#19629)
  Improve Wemo setup speed (home-assistant#19563)
  Support knx operation types (home-assistant#19546)
  Use xml.etree through defusedxml (home-assistant#19640)
  Fix cpu_temp issue on Vero 4K (home-assistant#19638)
  Added events STARTED, RESTARTED AND PAUSED (home-assistant#19516)
  Revert "Bump pyotgw to 0.4b0 (home-assistant#19618)" (home-assistant#19635)
  Upgrade to async_upnp_client==0.13.8 (home-assistant#19634)
  Upgraded pyarlo to 0.2.3 (home-assistant#19626)
  Fix cpu_temp issue on Odroid (home-assistant#19620)
  Bump pyotgw to 0.4b0 (home-assistant#19618)
  Add additional neato alerts and errors (home-assistant#19608)
  LCN component and light platform (home-assistant#18621)
  Systemmonitor - add device_class property (home-assistant#19614)
  Upgrade huawei-lte-api to 1.1.1 (home-assistant#19615)
  ...

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment