New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how neato displays alerts and add alerts for persistent maps #19593

Merged
merged 2 commits into from Dec 27, 2018

Conversation

Projects
None yet
3 participants
@dshokouhi
Copy link
Contributor

dshokouhi commented Dec 26, 2018

Description:

The old logic was looking for alerts in the wrong location, this PR corrects that. This PR adds some missing alerts and also ensures that alerts are shown even when the vacuum is not cleaning. Currently they only show up when the vacuum is in the cleaning state but some alerts persist beyond this state. This is helpful for certain alerts as the botvac may fail and only an alert is shown instead of an error. Neato defines errors as something that requires the user to press the "start" button on the vacuum, alerts may still require some type of user attention so this will ensure they are not missed. This is especially useful for when persistent maps are used.

Please note this PR is another attempt at #19238 as I made a mistake submitting the review comments. This PR also addresses the comments there.

Related issue (if applicable): fixes #N/A

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#N/A

Example entry for configuration.yaml (if applicable):

neato:
  username: username
  password: password

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
@dshokouhi

This comment has been minimized.

Copy link
Contributor

dshokouhi commented Dec 26, 2018

attempting to restart travis

@dshokouhi dshokouhi closed this Dec 26, 2018

@wafflebot wafflebot bot removed the in progress label Dec 26, 2018

@dshokouhi dshokouhi reopened this Dec 26, 2018

@wafflebot wafflebot bot added the in progress label Dec 26, 2018

@dshokouhi

This comment has been minimized.

Copy link
Contributor

dshokouhi commented Dec 26, 2018

@MartinHjelmare sorry for switching PR's had a bit of an issue with my last commit :) I have incorporated your review comments here. As always thank you for your review :)

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Great!

@MartinHjelmare MartinHjelmare merged commit d054504 into home-assistant:dev Dec 27, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.009%) to 93.056%
Details

@wafflebot wafflebot bot removed the in progress label Dec 27, 2018

@dshokouhi dshokouhi deleted the dshokouhi:neato_alert_improvement branch Dec 27, 2018

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment