New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated set of available voices for Yandex TTS #19603

Merged
merged 1 commit into from Dec 27, 2018

Conversation

Projects
None yet
3 participants
@gipnokote
Copy link
Contributor

gipnokote commented Dec 27, 2018

Description:

As many new voices became available in Yandex TTS, I've added them to the HA component. I have tested the code and the voices, they work fine. The source of added voices list is their demo page: https://webasr.yandex.net/ttsdemo.html (you can see available voices when you inspect the select box which says "Oksana")

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
@homeassistant

This comment was marked as resolved.

Copy link

homeassistant commented Dec 27, 2018

Hello @gipnokote,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

  1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

  2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

    • If you only made a single commit you should be able to run
      git commit --amend --author="Author Name <email@address.com>"
      
      (substituting Author Name and email@address.com for your actual information) to set the authorship information.
    • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
      1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
      2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
    • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

@gipnokote

This comment has been minimized.

Copy link
Contributor

gipnokote commented Dec 27, 2018

I accidentally made a commit with a different email; I've amended the commit and put my primary email.
I've also just noticed I haven't made changes in the documentation. I will add the voices there.

@fabaff fabaff added cla-recheck and removed cla-error labels Dec 27, 2018

@homeassistant

This comment was marked as resolved.

Copy link

homeassistant commented Dec 27, 2018

Hi @gipnokote,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@gipnokote gipnokote referenced this pull request Dec 27, 2018

Merged

Updated docs for Yandex TTS #7960

2 of 2 tasks complete
@fabaff

fabaff approved these changes Dec 27, 2018

Copy link
Member

fabaff left a comment

Thanks 🐦

@fabaff fabaff merged commit 4c59a65 into home-assistant:dev Dec 27, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot All contributors have signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.009%) to 93.056%
Details

@wafflebot wafflebot bot removed the in progress label Dec 27, 2018

@gipnokote gipnokote deleted the gipnokote:tts-yandex-patch-1 branch Dec 27, 2018

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment